Marks Linux_pixel_7pro drive_perf_debug_warning to be flaky #174112
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Code Review
This pull request correctly marks the Linux_pixel_7pro drive_perf_debug_warning test as flaky by setting bringup: true. My review includes one suggestion to align the comment with the project's documented conventions for marking flaky tests, which will improve maintainability.
| @@ -2706,6 +2706,7 @@ targets: | |||
| task_name: devtools_profile_start_test | |||
|
|
|||
| - name: Linux_pixel_7pro drive_perf_debug_warning | |||
| bringup: true # Flaky https://github.com/flutter/flutter/issues/174111 | |||
There was a problem hiding this comment.
To maintain consistency with the project's conventions for marking flaky tests, please format the comment as # TODO(username): github issue url and place it on the line above bringup: true. This convention is documented in the docs/infra/Reducing-Test-Flakiness.md file (line 34).
# TODO(<github_username>): https://github.com/flutter/flutter/issues/174111
bringup: true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link: #174111