Marks Linux_pixel_7pro new_gallery__transition_perf to be flaky #174106
Conversation
There was a problem hiding this comment.
Code Review
This pull request marks the Linux_pixel_7pro new_gallery__transition_perf test as flaky. The change is correct in principle, but the comment format for marking the test as flaky does not follow the documented convention in docs/infra/Reducing-Test-Flakiness.md. I've added a comment with a suggestion to align with the repository's guidelines.
| @@ -3190,6 +3190,7 @@ targets: | |||
|
|
|||
| # Pixel 7 Pro, Skia | |||
| - name: Linux_pixel_7pro new_gallery__transition_perf | |||
| bringup: true # Flaky https://github.com/flutter/flutter/issues/174105 | |||
There was a problem hiding this comment.
The comment format for marking a test as flaky doesn't follow the documented convention. According to docs/infra/Reducing-Test-Flakiness.md (line 34), the comment should be on a separate line above bringup: true and use the format # TODO(username): github issue url. Please update the comment to match this format, replacing <github_username> with the appropriate username.
# TODO(<github_username>): https://github.com/flutter/flutter/issues/174105
bringup: true
Issue link: #174105