Skip to content

Marks Mac_mokey microbenchmarks to be flaky #174102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Marks Mac_mokey microbenchmarks to be flaky #174102

wants to merge 1 commit into from
+1 −0

Conversation

fluttergithubbot
Copy link
Contributor

Issue link: #174101

@fluttergithubbot fluttergithubbot added the team-engine Owned by Engine team label Aug 20, 2025
@flutter-dashboard flutter-dashboard bot added c: flake Tests that sometimes, but not always, incorrectly pass c: tech-debt Technical debt, code quality, testing, etc. labels Aug 20, 2025
@github-actions github-actions bot removed c: tech-debt Technical debt, code quality, testing, etc. team-engine Owned by Engine team labels Aug 20, 2025
gemini-code-assist[bot]
gemini-code-assist bot reviewed Aug 20, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly marks the Mac_mokey microbenchmarks test as flaky in the .ci.yaml file by adding bringup: true. This is a standard procedure to prevent a flaky test from blocking the CI tree. The change is clear and includes a comment with a link to the corresponding issue for tracking. The implementation is correct, and I have no suggestions for improvement.

@matanlurey matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 20, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Aug 20, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 20, 2025
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matanlurey matanlurey matanlurey approved these changes

@jtmcdole jtmcdole Awaiting requested review from jtmcdole

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
c: flake Tests that sometimes, but not always, incorrectly pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fluttergithubbot @matanlurey