Remove obsolete vulkan_window source files #174087
Conversation
There was a problem hiding this comment.
Code Review
This pull request correctly removes the obsolete vulkan_window source files and their references in the build system and other headers. The change is clean and follows the stated purpose. I've found one minor issue in the updated documentation example where the hash value for the new example file seems to be outdated. Please see the specific comment for details. Otherwise, the changes look good.
| file_name="engine/src/flutter/display_list/display_list.h"; (printf "blob $(wc -c < "$file_name" | awk '{print $1}')\0"; cat "$file_name") | sha1sum | ||
| 11a5a03d15ae21bde366e41291a7899eec44e5ae - | ||
|
|
||
| git ls-tree -r HEAD engine/src/flutter/vulkan/vulkan_window.h | ||
| 100644 blob 11a5a03d15ae21bde366e41291a7899eec44e5ae engine/src/flutter/vulkan/vulkan_window.h | ||
| git ls-tree -r HEAD engine/src/flutter/display_list/display_list.h | ||
| 100644 blob 11a5a03d15ae21bde366e41291a7899eec44e5ae engine/src/flutter/display_list/display_list.h |
There was a problem hiding this comment.
The hash value 11a5a03d15ae21bde366e41291a7899eec44e5ae appears to be the hash of the deleted file vulkan_window.h. To keep the example in this documentation accurate, please update the hash to match the new file engine/src/flutter/display_list/display_list.h. You can regenerate it using the command on line 26.
|
I'm still finding more potentially obsolete code in the vulkan directory. Some of it is referenced outside that directory, but by code that is, itself, also dead. Working my way through the spaghetti... |
While doing some code surveys to see what surface/context files are being used, I discovered that these source files defined classes that were not used anywhere, so deleting them as dead code.