[Impeller] Make sure inline passes always do a clear action. #174083
Conversation
…could avoid this is no longer valid.
777611c to
596c1e2
Compare
|
dropping this out of draft to check goldens |
596c1e2 to
a0ec261
Compare
a0ec261 to
bebd734
Compare
|
This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
@flar @chinmaygarde can you guys give this a look. I've done a bit of debugging of this issue in #171772 This is a bummer of a change since it seems to work fine on some devices, like metal. But it clearly doesn't work for vulkan. I was hoping you might know something I don't know about how this optimization is supposed to work. I went back and it's been broken for almost a year so maybe it never did for these devices. |
| // drawing the previous pass texture, and so we don't have to clear it and | ||
| // can use kDontCare. | ||
| color0.load_action = is_msaa ? LoadAction::kDontCare : LoadAction::kLoad; | ||
| color0.load_action = is_msaa ? LoadAction::kClear : LoadAction::kLoad; |
There was a problem hiding this comment.
Perhaps add a comment that we should be able to use kDontCare here and it's not clear why that doesn't work - with an issue to follow up when we have the time?
The assumption they could avoid this is no longer valid.
issue: #171772
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.