[CP-stable]Add open_jdk to Linux linux_android_emulator.debug_x64
#174078
Conversation
…73989) Towards flutter#173986. This build _never_ declared (either directly or through `platform_properties`) that it required the Java JDK, and appears to have been "accidentally" getting it installed via a (now expired) cache of the Java JDK. I'll file a separate issue of "should platform properties be inherited by engine v2 sub-builds". /cc @jason-simmons @gaaclarke for FYI.
|
@matanlurey please fill out the PR description above, afterwards the release team will review this request. |
|
This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter. Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed. |
There was a problem hiding this comment.
Code Review
This pull request adds the open_jdk dependency to the Linux linux_android_emulator.debug_x64 build configuration. The change is a straightforward addition to a JSON file, and the syntax and formatting are correct. This appears to be a necessary dependency for running Android emulator tests on Linux. The change is consistent with the surrounding configuration and I have no further feedback.
18ecd85
into
flutter:flutter-3.35-candidate.0
|
@matanlurey asked for these to land to unbreak releases |
This pull request is created by automatic cherry pick workflow
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.
Issue Link:
What is the link to the issue this cherry-pick is addressing?
Stablize infrastructure.
Changelog Description:
Explain this cherry pick in one line that is accessible to most Flutter developers. See best practices for examples
N/A
Impact Description:
What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch)
Failed pre-submit/post-submit builds that are not actionable.
Workaround:
Is there a workaround for this issue?
No
Risk:
What is the risk level of this cherry-pick?
Test Coverage:
Are you confident that your fix is well-tested by automated tests?
Validation Steps:
What are the steps to validate that this fix works?
You can merge PRs.