[web] Fix error in ClickDebouncer when using VoiceOver #174046
Merged
+78
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Code Review
This pull request addresses an error in ClickDebouncer when using VoiceOver, where multiple pointer events could be fired within the same event loop. The fix introduces a two-phase initialization for the debouncer state. The state is now created immediately on pointerdown to queue subsequent events, while the actual debouncing timer is started asynchronously at the end of the event loop. This is a clean solution that correctly handles the race condition without affecting existing behavior for Safari. The changes are well-tested, with existing tests updated and a new test added to cover the specific bug scenario. The implementation looks solid.
|
autosubmit label was removed for flutter/flutter/174046, because - The status or check suite Linux linux_android_emulator_tests has failed. Please fix the issues identified (or deflake) before re-applying this label. |
|
Failed to create CP due to merge conflicts. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 20, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 20, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 20, 2025
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Aug 20, 2025
…9862) Manual roll Flutter from e65380a22076 to 960d1078f876 (36 revisions) Manual roll requested by bmparr@google.com flutter/flutter@e65380a...960d107 2025-08-20 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reapply "Add set semantics enabled API and wire iOS a11y bridge (#161… (#171198)" (flutter/flutter#174153) 2025-08-20 ahmedsameha1@gmail.com Make sure that a Badge doesn't crash in 0x0 environment (flutter/flutter#172065) 2025-08-20 ahmedsameha1@gmail.com Make sure that CalendarDatePicker & YearPicker don't crash in 0x0 environment (flutter/flutter#173408) 2025-08-20 engine-flutter-autoroll@skia.org Roll Packages from 953cae0 to 58c02e0 (2 revisions) (flutter/flutter#174142) 2025-08-20 ahmedsameha1@gmail.com Make sure that a CircleAvatar doesn't crash in 0x0 environment (flutter/flutter#173498) 2025-08-20 engine-flutter-autoroll@skia.org Roll Dart SDK from 0d674ff61e2e to 0d0a0c394381 (1 revision) (flutter/flutter#174126) 2025-08-20 34871572+gmackall@users.noreply.github.com [Android] Fix version code override calculation in FlutterPlugin (flutter/flutter#174081) 2025-08-20 ahmedsameha1@gmail.com Make sure that a BackButton doesn't crash in 0x0 environment (flutter/flutter#172817) 2025-08-20 engine-flutter-autoroll@skia.org Roll Dart SDK from c5f5a32df36c to 0d674ff61e2e (1 revision) (flutter/flutter#174099) 2025-08-20 100504385+AlsoShantanuBorkar@users.noreply.github.com feat: Added FocusNode prop for DropdownMenu Trailing Icon Button (flutter/flutter#172753) 2025-08-20 32538273+ValentinVignal@users.noreply.github.com Make component theme data defaults use `WidgetStateProperty` (flutter/flutter#173893) 2025-08-20 huy@nevercode.io Fix Menu anchor reduce padding on web and desktop (flutter/flutter#172691) 2025-08-20 engine-flutter-autoroll@skia.org Roll Skia from 4b788d0e5e63 to 721e68fe652a (2 revisions) (flutter/flutter#174095) 2025-08-20 bruno.leroux@gmail.com Fix time picker period selector a11y touch targets (flutter/flutter#170060) 2025-08-20 bruno.leroux@gmail.com Fix SegmentedButton focus issue (flutter/flutter#173953) 2025-08-20 engine-flutter-autoroll@skia.org Roll Dart SDK from e936404543f1 to c5f5a32df36c (1 revision) (flutter/flutter#174089) 2025-08-20 engine-flutter-autoroll@skia.org Roll Skia from 953bfc0e2f2a to 4b788d0e5e63 (1 revision) (flutter/flutter#174086) 2025-08-19 engine-flutter-autoroll@skia.org Roll Skia from 07d71ea4d056 to 953bfc0e2f2a (18 revisions) (flutter/flutter#174072) 2025-08-19 engine-flutter-autoroll@skia.org Roll Dart SDK from 9105d946af95 to e936404543f1 (5 revisions) (flutter/flutter#174074) 2025-08-19 victorsanniay@gmail.com NavigationRail correct traversal order (flutter/flutter#173891) 2025-08-19 victorsanniay@gmail.com Update CupertinoSliverNavigationBar.middle (flutter/flutter#173868) 2025-08-19 matt.kosarek@canonical.com Update the AccessibilityPlugin::Announce method to account for the view (flutter/flutter#172669) 2025-08-19 bkonyi@google.com [ Widget Preview ] Report an error if a web device is unavailable (flutter/flutter#174036) 2025-08-19 mdebbar@google.com [web] Fix error in ClickDebouncer when using VoiceOver (flutter/flutter#174046) 2025-08-19 bkonyi@google.com [ Tool ] Add logging to test_adapter_test.dart (flutter/flutter#174073) 2025-08-19 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from n0EnLlotF2wczlOq_... to V1A1J6uXZ62Q10i9u... (flutter/flutter#174059) 2025-08-19 matanlurey@users.noreply.github.com Cleanup legacy `bringup: true` tasks, either removing or enabling (flutter/flutter#173815) 2025-08-19 sokolovskyi.konstantin@gmail.com Add Shift+Enter shortcut example for TextField. (flutter/flutter#167952) 2025-08-19 131267808+SvenGasterstaedt@users.noreply.github.com Check that the windows architecture is 64-bit and not the process architecture (flutter/flutter#174019) 2025-08-19 56561849+Rushikeshbhavsar20@users.noreply.github.com Improve Stack widget error message for bounded constraints (flutter/flutter#173352) 2025-08-19 42980667+srivats22@users.noreply.github.com [VPAT][A11y] AutoComplete dropdown option is missing button role (flutter/flutter#173297) 2025-08-19 simonpham.dn@gmail.com fix: Android build fails when minSdk is set below 24 in build.gradle.kts (#173823) (flutter/flutter#173825) 2025-08-19 47866232+chunhtai@users.noreply.github.com Reapply "Add set semantics enabled API and wire iOS a11y bridge (#161… (flutter/flutter#171198) 2025-08-19 yvesdelcoigne@gmail.com fix: only use library props for libraries (flutter/flutter#172704) 2025-08-19 engine-flutter-autoroll@skia.org Roll Packages from 5c52c55 to 953cae0 (22 revisions) (flutter/flutter#174040) 2025-08-19 matanlurey@users.noreply.github.com Add `open_jdk` to `Linux linux_android_emulator.debug_x64` (flutter/flutter#173989) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose ...
SydneyBao
pushed a commit
to SydneyBao/flutter
that referenced
this pull request
Aug 22, 2025
When using VoiceOver, clicking the button through `ctrl+opt+space` causes the browser to send `pointerdown`, `pointerup` and `click` events successively within the same event loop. This case wasn't handled correct by the recent `ClickDebouncer` change here: flutter#172995 More details: We currently wait until the end of the event loop to set the `ClickDebouncer`'s state. When other events arrive before the end of the event loop, they expect the `state` to already be set. The fix is to set the `state` immediately to allow events to be queued right away, but still keep the debouncing delayed until the end of the event loop so that Safari continues to work correctly (issue: flutter#172180) Fixes flutter#173741
SydneyBao
pushed a commit
to SydneyBao/flutter
that referenced
this pull request
Aug 22, 2025
When using VoiceOver, clicking the button through `ctrl+opt+space` causes the browser to send `pointerdown`, `pointerup` and `click` events successively within the same event loop. This case wasn't handled correct by the recent `ClickDebouncer` change here: flutter#172995 More details: We currently wait until the end of the event loop to set the `ClickDebouncer`'s state. When other events arrive before the end of the event loop, they expect the `state` to already be set. The fix is to set the `state` immediately to allow events to be queued right away, but still keep the debouncing delayed until the end of the event loop so that Safari continues to work correctly (issue: flutter#172180) Fixes flutter#173741
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using VoiceOver, clicking the button through
ctrl+opt+spacecauses the browser to sendpointerdown,pointerupandclickevents successively within the same event loop. This case wasn't handled correct by the recentClickDebouncerchange here: #172995More details:
We currently wait until the end of the event loop to set the
ClickDebouncer's state. When other events arrive before the end of the event loop, they expect thestateto already be set.The fix is to set the
stateimmediately to allow events to be queued right away, but still keep the debouncing delayed until the end of the event loop so that Safari continues to work correctly (issue: #172180)Fixes #173741