Make sure that a Dialog doesn't crash in 0x0 environment #174023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Code Review
This pull request introduces a regression test to prevent a crash when a Dialog is rendered in a zero-sized environment. The added test case is clear and covers the intended scenario. I've suggested an improvement to make the test more robust by adding an assertion, in line with the repository's testing guidelines. Note that the fix for the underlying crash is not included in this pull request; I assume it is handled separately.
victorsanni
approved these changes
Aug 22, 2025
There was a problem hiding this comment.
LGTM, but following up from the discussion here, I'm not sure how to proceed, wdyt @LongCatIsLooong ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my attempt to handle #6537 for the Dialog UI control.