[CP] Blocks exynos9820 chip from vulkan #173981
Conversation
fixes flutter#171992 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md (cherry picked from commit 4abea34)
|
This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter. Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed. |
There was a problem hiding this comment.
Code Review
This pull request cherry-picks a fix to block certain Exynos SoCs (exynos9820 and exynos9825) from using Vulkan due to driver issues, forcing a fallback to OpenGL. The changes look good, including renaming the blocklist for clarity and adding a helpful log message when the fallback is triggered. I have one suggestion to improve a comment to make it more accurate for all SoCs in the list, which will help with future maintenance.
| static constexpr const char* kBLC[] = { | ||
| // Most Exynos Series SoC | ||
| static constexpr const char* kBadSocs[] = { | ||
| // Most Exynos Series SoC. These are SoCs that crash when using AHB imports. |
There was a problem hiding this comment.
The comment on this line is slightly inaccurate. It states that the SoCs in this list crash, but exynos9820 and exynos9825 are being added due to graphical errors, as noted in the comments for those entries. For better accuracy and maintainability, please consider making this comment more general to cover all types of issues. 1
| // Most Exynos Series SoC. These are SoCs that crash when using AHB imports. | |
| // Most Exynos Series SoC. These are SoCs with known driver issues (crashes, graphical glitches, etc.). |
Style Guide References
Footnotes
|
autosubmit label was removed for flutter/flutter/173981, because This PR has not met approval requirements for merging. The PR author is not a member of flutter-hackers and needs 1 more review(s) in order to merge this PR.
|
44ff99c
into
flutter:flutter-3.35-candidate.0
(cherry picked from commit 4abea34)
Fixes of #171992 for the stable branch.
Cherry-pick of #173807 onto stable.
Impacted Users
Developers and end-users of Flutter applications running on Samsung Galaxy S10 or Note 10 series devices equipped with Exynos 9820/9825 SoCs.
Impact Description
Due to malfunctioning Vulkan drivers on these SoCs, platform views that rely on
SurfaceViewfail to render correctly. The original PR addresses this by blocklisting the affected SoCs, forcing them to use Impeller with OpenGL ES instead of Vulkan.Workaround
Aside from setting
io.flutter.embedding.android.ImpellerBackend(which is not available in production) or disabling Impeller entirely, there is no practical workaround for this issue on affected devices.Risk
The risk of this cherry-pick is low. The original PR only adds specific SoCs to the blocklist and renames a static variable, which does not affect other devices regardless of whether they use this mechanism.
Test Coverage
Due to the nature of the issue and the fix, validation can only be performed through manual testing on the affected devices. As the reporter of the original issue, I have verified the fix on the Galaxy S10 5G(SM-G977N, Exynos 9820), confirming that the change resolves the rendering problem.
Validation Steps
SurfaceView(e.g., https://github.com/bc-lee/test-flutter-android-texture or https://github.com/gaaclarke/surface_platformview).Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.