[Gradle 9] Removed minSdkVersion and only use minSdk
#173892
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
There was a problem hiding this comment.
Code Review
This pull request correctly removes the usage of the deprecated minSdkVersion property in favor of minSdk, which is necessary for Gradle 9 support. The changes simplify the logic by removing the Android Gradle Plugin (AGP) version check, as the minimum supported AGP version now guarantees the availability of minSdk.
My review includes suggestions to improve naming consistency in the changed code, aligning function and variable names with the minSdk property to enhance readability and maintainability. The changes are otherwise correct and well-justified.
| @@ -155,7 +155,7 @@ object DependencyVersionChecker { | |||
| val minSdkCheckTask = | |||
| project.tasks.register(taskName) { | |||
| doLast { | |||
| val minSdkVersion = getMinSdkVersion(project, it) | |||
| val minSdkVersion = getMinSdkVersion(it) | |||
There was a problem hiding this comment.
To align with the proposed rename of getMinSdkVersion and the PR's intent, let's update the call here and rename the local variable. For full consistency, you might consider renaming the MinSdkVersion class and checkMinSdkVersion function in a follow-up, as their definitions are outside this PR's scope.
| val minSdkVersion = getMinSdkVersion(it) | |
| val minSdk = getMinSdk(it) |
| @@ -181,19 +181,8 @@ object DependencyVersionChecker { | |||
| private fun generateMinSdkCheckTaskName(it: Variant) = "${FlutterPluginUtils.capitalize(it.name)}$MIN_SDK_CHECK_TASK_POSTFIX" | |||
|
|
|||
| private fun getMinSdkVersion( | |||
There was a problem hiding this comment.
Since this PR's goal is to use minSdk instead of minSdkVersion, consider renaming this function to getMinSdk for better clarity and consistency. The call site at line 158 will also need to be updated.
| private fun getMinSdkVersion( | |
| private fun getMinSdk( |
There was a problem hiding this comment.
@jesswrd I disagree here.
| MinSdkVersion(it.name, it.minSdkVersion.apiLevel) | ||
| } | ||
| } | ||
| ): MinSdkVersion = MinSdkVersion(it.name, it.minSdk.apiLevel) |
There was a problem hiding this comment.
@gmackall what are your thoughts on removing this method and inlining the implementation vs just modifying the implementation like is done here.
Support for
minSdkVersionis completely dropped in Gradle 9, and we should only useminSdk. We also included an AGP version checker to ensure builds did not crash when getting the minimum sdk version. Since our minimum AGP version is now 8.3, we can remove agp version check.Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.