Skip to content

Update CHANGELOG.md to include link to 3.35 changelog #173869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 18, 2025
Merged

Update CHANGELOG.md to include link to 3.35 changelog #173869

merged 2 commits into from
Aug 18, 2025

Conversation

sethladd
Copy link
Contributor

add link to 3.35 blog post as proxy for 3.35 changelog

Pre-launch Checklist

  • [ x] I signed the [CLA].

@sethladd
Update CHANGELOG.md to include link to 3.35 changelog
985ccf2 
add link to 3.35 blog post as proxy for 3.35 changelog
@flutter-dashboard flutter-dashboard bot changed the base branch from stable to master August 15, 2025 18:48
@flutter-dashboard flutter-dashboard bot requested review from a team and matanlurey as code owners August 15, 2025 18:48
@flutter-dashboard
Copy link

This pull request was opened against a branch other than master. Since Flutter pull requests should not normally be opened against branches other than master, I have changed the base to master. If this was intended, you may modify the base back to stable. See the Release Process for information about how other branches get updated.

Reviewers: Use caution before merging pull requests to branches other than master, unless this is an intentional hotfix/cherrypick.

@github-actions github-actions bot added a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems platform-android Android applications specifically platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. framework flutter/packages/flutter repository. See also f: labels. engine flutter/engine repository. See also e: labels. a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) platform-web Web applications specifically platform-linux Building on or for Linux specifically a: desktop Running on desktop f: integration_test The flutter/packages/integration_test plugin team-ios Owned by iOS platform team labels Aug 15, 2025
gemini-code-assist[bot]
gemini-code-assist bot reviewed Aug 15, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces significant changes beyond what the title suggests. While the title mentions updating CHANGELOG.md, the core of this PR is a major refactoring of the iOS device deployment and debugging workflow, notably adding support for LLDB-based debugging for CoreDevices. This includes:

  • A new IOSCoreDeviceLauncher to handle different launch strategies.
  • A new lldb.dart library to interact with the LLDB process.
  • Refactoring of IOSDevice to use the new launcher and decide between LLDB and Xcode debugging.
  • Updates to devicectl interaction in core_devices.dart.
  • Refactoring of the last_engine_commit scripts to be more robust on release branches.

The changes appear to be well-structured and improve the iOS tooling. My main feedback is a small robustness improvement for the last_engine_commit.sh script to handle cases where a file might not exist, ensuring custom error messages are displayed correctly.

bin/internal/last_engine_commit.sh Outdated
MERGE_BASE_COMMIT="$(git merge-base HEAD master || echo "")"
# 1. Determine when the release branch was started, and prevent set -e from exiting.
RELEASE_CANDIDATE_VERSION_PATH="$(git rev-parse --show-toplevel)/bin/internal/release-candidate-branch.version"
REFERENCE_COMMIT="$(git log -1 --pretty=format:%H -- "$RELEASE_CANDIDATE_VERSION_PATH")"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This command will cause the script to exit if git log fails (e.g., if $RELEASE_CANDIDATE_VERSION_PATH doesn't exist), due to set -e. This would prevent your custom error message below from being displayed. To ensure your custom error handling is triggered, you should prevent the script from exiting on failure here, similar to how the old script handled git merge-base.

You can append || true to the command to prevent it from exiting the script on failure.

Suggested change
REFERENCE_COMMIT="$(git log -1 --pretty=format:%H -- "$RELEASE_CANDIDATE_VERSION_PATH")"
REFERENCE_COMMIT="$(git log -1 --pretty=format:%H -- "$RELEASE_CANDIDATE_VERSION_PATH" || true)"

@jmagman jmagman changed the base branch from master to stable August 15, 2025 21:08
@jmagman jmagman changed the base branch from stable to flutter-3.35-candidate.0 August 15, 2025 21:09
@flutter-dashboard
Copy link

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@fluttergithubbot
Copy link
Contributor

An existing Git SHA, 985ccf25167909e64b12af3237c94205b8e1df96, was detected, and no actions were taken.

To re-trigger presubmits after closing or re-opeing a PR, or pushing a HEAD commit (i.e. with --force) that already was pushed before, push a blank commit (git commit --allow-empty -m "Trigger Build") or rebase to continue.

vashworth
vashworth approved these changes Aug 15, 2025
View reviewed changes
Copy link
Contributor

@vashworth vashworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman
Copy link
Member

jmagman commented Aug 15, 2025

Changed the base branch to flutter-3.35-candidate.0

@jmagman jmagman removed a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems platform-android Android applications specifically platform-ios iOS applications specifically labels Aug 15, 2025
@jmagman jmagman removed tool Affects the "flutter" command-line tool. See also t: labels. framework flutter/packages/flutter repository. See also f: labels. engine flutter/engine repository. See also e: labels. a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) platform-web Web applications specifically platform-linux Building on or for Linux specifically a: desktop Running on desktop f: integration_test The flutter/packages/integration_test plugin team-ios Owned by iOS platform team labels Aug 15, 2025
@vashworth
Copy link
Contributor

@camsim99 Can you merge this in?

@camsim99 camsim99 added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 15, 2025
@reidbaker reidbaker added the emergency Jump the queue; land PR in front of all others; only use for emergencies label Aug 18, 2025
@flutter-dashboard
Copy link

Detected the emergency label.

If you add the autosubmit label, the bot will wait until all presubmits pass but ignore the tree status, allowing fixes for tree breakages while still validating that they don't break any existing presubmits.

The "Merge" button is also unlocked. To bypass presubmits as well as the tree status, press the GitHub "Add to Merge Queue".

@reidbaker
Copy link
Contributor

Adding emergency label to override tree status which should probably not apply to release branches.

@reidbaker reidbaker mentioned this pull request Aug 18, 2025
Closed
4 tasks
@sethladd
Copy link
Contributor Author

Thank you for the help here!

@reidbaker
Copy link
Contributor

@sethladd According to this response #173966 (comment) you need to push an amendment or new commit to retrigger ci.yaml validation. I am not aware of another way to rerun or unstall that check and that check ignores the emergency label.

The good news is that changelog only prs run a very small subset of tests so hopefully it will be fast.

@reidbaker reidbaker removed the emergency Jump the queue; land PR in front of all others; only use for emergencies label Aug 18, 2025
@sethladd
Copy link
Contributor Author

thanks! pushed a cosmetic change

@auto-submit Auto-submit
Copy link
Contributor

auto-submit bot commented Aug 18, 2025

autosubmit label was removed for flutter/flutter/173869, because - The status or check suite Linux analyze has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 18, 2025
@reidbaker
Copy link
Contributor

Re-runnning linux analyze. It found ktlint violations but that appears to be because java was missing.
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8706177227087661089/+/u/run_test.dart_for_analyze_shard_and_subshard_None/stdout

@reidbaker reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 18, 2025
@sethladd
Copy link
Contributor Author

Thank you!

@matanlurey
Copy link
Contributor

Re-runnning linux analyze. It found ktlint violations but that appears to be because java was missing. https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8706177227087661089/+/u/run_test.dart_for_analyze_shard_and_subshard_None/stdout

Just to be clear, it doesn't look like we install the Java (JDK) during this builder:

flutter/.ci.yaml

Lines 349 to 351 in 2265d94

dependencies: >-
[
{"dependency": "ktlint", "version": "version_1_5_0"}

@auto-submit auto-submit bot merged commit f87e9cd into flutter-3.35-candidate.0 Aug 18, 2025
10 checks passed
@auto-submit auto-submit bot deleted the sethladd-patch-1 branch August 18, 2025 18:32
@reidbaker reidbaker mentioned this pull request Aug 18, 2025
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reidbaker reidbaker reidbaker approved these changes

@vashworth vashworth vashworth approved these changes

@matanlurey matanlurey Awaiting requested review from matanlurey

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@sethladd @fluttergithubbot @jmagman @vashworth @reidbaker @matanlurey @camsim99