Skip to content

Roll package:analyzer forward to 8.1.1 #173867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 15, 2025
Merged

Roll package:analyzer forward to 8.1.1 #173867

merged 6 commits into from
Aug 15, 2025

Conversation

bkonyi
Copy link
Contributor

@bkonyi bkonyi commented Aug 15, 2025

No description provided.

@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Aug 15, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates several dependencies, most notably upgrading the analyzer package from version 7.4.5 to 8.1.1. My review focuses on this major version change. I've identified a critical issue: the analyzer upgrade introduces breaking API changes, but this PR does not include the necessary code modifications to adapt to them. This will likely lead to build failures.

@github-actions github-actions bot added the f: material design flutter/packages/flutter/material repository. label Aug 15, 2025
@github-actions github-actions bot removed the f: material design flutter/packages/flutter/material repository. label Aug 15, 2025
@bkonyi bkonyi marked this pull request as ready for review August 15, 2025 21:32
@bkonyi bkonyi requested a review from matanlurey as a code owner August 15, 2025 21:33
@bkonyi bkonyi requested a review from chingjun August 15, 2025 21:33
@bkonyi bkonyi added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 15, 2025
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 15, 2025
Copy link
Contributor

auto-submit bot commented Aug 15, 2025

autosubmit label was removed for flutter/flutter/173867, because - The status or check suite Mac tool_integration_tests_4_5 has failed. Please fix the issues identified (or deflake) before re-applying this label.

@bkonyi bkonyi added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 15, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Aug 15, 2025
Merged via the queue into master with commit 37848d1 Aug 15, 2025
157 checks passed
@auto-submit auto-submit bot deleted the roll_analyzer_8.1.1 branch August 15, 2025 23:52
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 15, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Aug 16, 2025
flutter/flutter@52af7a5...0a2906b

2025-08-16 31685655+SalehTZ@users.noreply.github.com Improve `SweepGradient` angle and `TileMode` documentation (flutter/flutter#172406)
2025-08-16 engine-flutter-autoroll@skia.org Roll Skia from 1e148cada9d4 to 16dbd908dcab (1 revision) (flutter/flutter#173901)
2025-08-16 engine-flutter-autoroll@skia.org Roll Skia from 91ad1f21ca61 to 1e148cada9d4 (3 revisions) (flutter/flutter#173890)
2025-08-16 engine-flutter-autoroll@skia.org Roll Dart SDK from 9277d6303da5 to 67ca79475db6 (1 revision) (flutter/flutter#173886)
2025-08-15 30870216+gaaclarke@users.noreply.github.com Blocks exynos9820 chip from vulkan (flutter/flutter#173807)
2025-08-15 41930132+hellohuanlin@users.noreply.github.com Revert "[ios][tools]do not log "bonjour not found" at all (unless verbose)" (flutter/flutter#173879)
2025-08-15 bkonyi@google.com Roll `package:analyzer` forward to `8.1.1` (flutter/flutter#173867)
2025-08-15 engine-flutter-autoroll@skia.org Roll Skia from 2f66be8a593a to 91ad1f21ca61 (3 revisions) (flutter/flutter#173877)
2025-08-15 jhy03261997@gmail.com [a11y] : set isFocused will update isFocusable to true (flutter/flutter#170935)
2025-08-15 jmccandless@google.com Reland predictive back route transitions by default (flutter/flutter#173860)
2025-08-15 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from zWRpLglb48zC1vZLv... to H1kVA85LyQsK8EDp2... (flutter/flutter#173874)
2025-08-15 lauraywu@google.com Add onHover callback support for TableRowInkWell (flutter/flutter#173373)
2025-08-15 engine-flutter-autoroll@skia.org Roll Skia from 5654ac32ede0 to 2f66be8a593a (6 revisions) (flutter/flutter#173866)
2025-08-15 engine-flutter-autoroll@skia.org Roll Dart SDK from cc008dc8e7aa to 9277d6303da5 (2 revisions) (flutter/flutter#173864)
2025-08-15 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Implements the Android native stretch effect as a fragment shader (Impeller-only). (#169293)" (flutter/flutter#173865)
2025-08-15 matanlurey@users.noreply.github.com Re-add `Linux_android_emu *` tests that had KVM issues, now resolved (flutter/flutter#173812)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC louisehsu@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
ksokolovskyi pushed a commit to ksokolovskyi/flutter that referenced this pull request Aug 19, 2025
WillBLogical pushed a commit to WillBLogical/packages that referenced this pull request Aug 20, 2025
…r#9836)

flutter/flutter@52af7a5...0a2906b

2025-08-16 31685655+SalehTZ@users.noreply.github.com Improve `SweepGradient` angle and `TileMode` documentation (flutter/flutter#172406)
2025-08-16 engine-flutter-autoroll@skia.org Roll Skia from 1e148cada9d4 to 16dbd908dcab (1 revision) (flutter/flutter#173901)
2025-08-16 engine-flutter-autoroll@skia.org Roll Skia from 91ad1f21ca61 to 1e148cada9d4 (3 revisions) (flutter/flutter#173890)
2025-08-16 engine-flutter-autoroll@skia.org Roll Dart SDK from 9277d6303da5 to 67ca79475db6 (1 revision) (flutter/flutter#173886)
2025-08-15 30870216+gaaclarke@users.noreply.github.com Blocks exynos9820 chip from vulkan (flutter/flutter#173807)
2025-08-15 41930132+hellohuanlin@users.noreply.github.com Revert "[ios][tools]do not log "bonjour not found" at all (unless verbose)" (flutter/flutter#173879)
2025-08-15 bkonyi@google.com Roll `package:analyzer` forward to `8.1.1` (flutter/flutter#173867)
2025-08-15 engine-flutter-autoroll@skia.org Roll Skia from 2f66be8a593a to 91ad1f21ca61 (3 revisions) (flutter/flutter#173877)
2025-08-15 jhy03261997@gmail.com [a11y] : set isFocused will update isFocusable to true (flutter/flutter#170935)
2025-08-15 jmccandless@google.com Reland predictive back route transitions by default (flutter/flutter#173860)
2025-08-15 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from zWRpLglb48zC1vZLv... to H1kVA85LyQsK8EDp2... (flutter/flutter#173874)
2025-08-15 lauraywu@google.com Add onHover callback support for TableRowInkWell (flutter/flutter#173373)
2025-08-15 engine-flutter-autoroll@skia.org Roll Skia from 5654ac32ede0 to 2f66be8a593a (6 revisions) (flutter/flutter#173866)
2025-08-15 engine-flutter-autoroll@skia.org Roll Dart SDK from cc008dc8e7aa to 9277d6303da5 (2 revisions) (flutter/flutter#173864)
2025-08-15 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Implements the Android native stretch effect as a fragment shader (Impeller-only). (#169293)" (flutter/flutter#173865)
2025-08-15 matanlurey@users.noreply.github.com Re-add `Linux_android_emu *` tests that had KVM issues, now resolved (flutter/flutter#173812)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC louisehsu@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
SydneyBao pushed a commit to SydneyBao/flutter that referenced this pull request Aug 22, 2025
SydneyBao pushed a commit to SydneyBao/flutter that referenced this pull request Aug 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants