Remove embedded_android_views (on-device) tests, same as emulator test
#173814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
reidbaker
approved these changes
Aug 18, 2025
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 18, 2025
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Aug 18, 2025
flutter/flutter@b3fb4c7...2265d94 2025-08-18 matanlurey@users.noreply.github.com Remove `embedded_android_views` (on-device) tests, same as emulator test (flutter/flutter#173814) 2025-08-18 engine-flutter-autoroll@skia.org Roll Skia from 3a17208059ec to 07d71ea4d056 (4 revisions) (flutter/flutter#173942) 2025-08-18 engine-flutter-autoroll@skia.org Roll Skia from 978726c1e725 to 3a17208059ec (2 revisions) (flutter/flutter#173939) 2025-08-18 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from sLmXksm1vZl2VEeA7... to n0EnLlotF2wczlOq_... (flutter/flutter#173936) 2025-08-18 huy@nevercode.io Enhance FilledButton and Theme Data's documentation to clarify platform-specific visual density behavior (flutter/flutter#173695) 2025-08-18 engine-flutter-autoroll@skia.org Roll Skia from 88e8c099a086 to 978726c1e725 (3 revisions) (flutter/flutter#173935) 2025-08-18 engine-flutter-autoroll@skia.org Roll Dart SDK from a874859559e6 to 502455ee300b (1 revision) (flutter/flutter#173934) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
WillBLogical
pushed a commit
to WillBLogical/packages
that referenced
this pull request
Aug 20, 2025
…#9845) flutter/flutter@b3fb4c7...2265d94 2025-08-18 matanlurey@users.noreply.github.com Remove `embedded_android_views` (on-device) tests, same as emulator test (flutter/flutter#173814) 2025-08-18 engine-flutter-autoroll@skia.org Roll Skia from 3a17208059ec to 07d71ea4d056 (4 revisions) (flutter/flutter#173942) 2025-08-18 engine-flutter-autoroll@skia.org Roll Skia from 978726c1e725 to 3a17208059ec (2 revisions) (flutter/flutter#173939) 2025-08-18 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from sLmXksm1vZl2VEeA7... to n0EnLlotF2wczlOq_... (flutter/flutter#173936) 2025-08-18 huy@nevercode.io Enhance FilledButton and Theme Data's documentation to clarify platform-specific visual density behavior (flutter/flutter#173695) 2025-08-18 engine-flutter-autoroll@skia.org Roll Skia from 88e8c099a086 to 978726c1e725 (3 revisions) (flutter/flutter#173935) 2025-08-18 engine-flutter-autoroll@skia.org Roll Dart SDK from a874859559e6 to 502455ee300b (1 revision) (flutter/flutter#173934) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
SydneyBao
pushed a commit
to SydneyBao/flutter
that referenced
this pull request
Aug 22, 2025
…est (flutter#173814) These tests are identical to the `Linux_android_emu` test that runs on presubmit: https://github.com/flutter/flutter/blob/9583f282a50f88a269f5716f1ecfe42f6b6387a3/.ci.yaml#L408-L416 These tests do not report benchmarks or any other statistics that would benefit from a real (on-device) test.
SydneyBao
pushed a commit
to SydneyBao/flutter
that referenced
this pull request
Aug 22, 2025
…est (flutter#173814) These tests are identical to the `Linux_android_emu` test that runs on presubmit: https://github.com/flutter/flutter/blob/9583f282a50f88a269f5716f1ecfe42f6b6387a3/.ci.yaml#L408-L416 These tests do not report benchmarks or any other statistics that would benefit from a real (on-device) test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests are identical to the
Linux_android_emutest that runs on presubmit:flutter/.ci.yaml
Lines 408 to 416 in 9583f28
These tests do not report benchmarks or any other statistics that would benefit from a real (on-device) test.