Make sure that a DateRangePickerDialog doesn't crash in 0x0 environments #173754
Conversation
There was a problem hiding this comment.
Code Review
This pull request adds a regression test to ensure that DateRangePickerDialog does not crash when rendered in a zero-sized environment, addressing a reported issue. The test case is well-defined and covers the scenario. My review includes a couple of suggestions to improve the test's maintainability and clarity by adding a comment linking to the original issue and explicitly asserting that no exceptions are thrown, which are common practices in this test file.
| @@ -1967,6 +1967,16 @@ void main() { | |||
| expect(getDayCount(secondMonthItem), 21); | |||
| }); | |||
| }); | |||
|
|
|||
| testWidgets('DateRangePickerDialog renders at zero area', (WidgetTester tester) async { | |||
There was a problem hiding this comment.
For better maintainability and to provide context for this test, it's a good practice to add a comment linking to the issue it's fixing. This is a common pattern in this test file.
// Regression test for https://github.com/flutter/flutter/issues/6537
testWidgets('DateRangePickerDialog renders at zero area', (WidgetTester tester) async {
| ); | ||
| }); |
There was a problem hiding this comment.
To make the test's intent clearer and more robust, it's good practice to explicitly assert that no exception was thrown during widget rendering. This pattern is used in other tests in this file.
);
expect(tester.takeException(), isNull);
});
This is my attempt to handle #6537 for the DateRangePickerDialog UI control.