Skip to content

Engine Support for Dynamic View Resizing #173610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 26 commits into
base: master
Choose a base branch
from
Open

Engine Support for Dynamic View Resizing #173610

wants to merge 26 commits into from
+365 −112

Conversation

LouiseHsu
Copy link
Contributor

@LouiseHsu LouiseHsu commented Aug 12, 2025 •
edited
Loading

Part of #169147 (iOS) and #149033 (Android). Implementation PRs coming up!

This enables support for dynamic view resizing in non-web embedders. While this PR enables support, it does not implement support.

Related PRs:
dart:ui: flutter/engine#48090
framework: #138648
framework reland: #140918
Web: flutter/engine#50271

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@github-actions github-actions bot added engine flutter/engine repository. See also e: labels. f: scrolling Viewports, list views, slivers, etc. labels Aug 12, 2025
gemini-code-assist[bot]
gemini-code-assist bot reviewed Aug 12, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the necessary engine-side support for dynamic view resizing. The changes correctly plumb through view constraints from the embedder to the framework. My review identified a functional issue where new constraint parameters are ignored in hooks.dart, a documentation error in platform_dispatcher.dart, a minor typo, and a C++ style guide violation in shell.h. Addressing these points will improve the correctness and quality of the implementation.

@flutter flutter deleted a comment from gemini-code-assist bot Aug 12, 2025
@LouiseHsu
Copy link
Contributor Author

This PR still needs tests btw.

mboetger
mboetger reviewed Aug 12, 2025
View reviewed changes
mboetger
mboetger reviewed Aug 12, 2025
View reviewed changes
loic-sharma
loic-sharma reviewed Aug 12, 2025
View reviewed changes
loic-sharma
loic-sharma reviewed Aug 12, 2025
View reviewed changes
loic-sharma
loic-sharma reviewed Aug 12, 2025
View reviewed changes
loic-sharma
loic-sharma reviewed Aug 12, 2025
View reviewed changes
loic-sharma
loic-sharma reviewed Aug 12, 2025
View reviewed changes
loic-sharma
loic-sharma reviewed Aug 12, 2025
View reviewed changes
mboetger
mboetger reviewed Aug 12, 2025
View reviewed changes
@github-actions github-actions bot added platform-android Android applications specifically team-android Owned by Android platform team labels Aug 13, 2025
@github-actions github-actions bot removed platform-android Android applications specifically team-android Owned by Android platform team labels Aug 19, 2025
mboetger
mboetger reviewed Aug 19, 2025
View reviewed changes
@mboetger mboetger requested a review from loic-sharma August 19, 2025 18:48
@mboetger mboetger marked this pull request as ready for review August 19, 2025 18:48
loic-sharma
loic-sharma reviewed Aug 20, 2025
View reviewed changes
loic-sharma
loic-sharma reviewed Aug 20, 2025
View reviewed changes
loic-sharma
loic-sharma reviewed Aug 20, 2025
View reviewed changes
vashworth
vashworth reviewed Aug 21, 2025
View reviewed changes
vashworth
vashworth reviewed Aug 21, 2025
View reviewed changes
vashworth
vashworth reviewed Aug 21, 2025
View reviewed changes
@mboetger mboetger requested a review from a team as a code owner August 21, 2025 18:24
@github-actions github-actions bot added platform-android Android applications specifically team-android Owned by Android platform team labels Aug 21, 2025
@github-actions github-actions bot added the platform-fuchsia Fuchsia code specifically label Aug 21, 2025
@mboetger mboetger requested a review from loic-sharma August 21, 2025 21:23
@mboetger mboetger requested a review from a team as a code owner August 21, 2025 21:45
@github-actions github-actions bot added platform-ios iOS applications specifically team-ios Owned by iOS platform team labels Aug 21, 2025
@github-actions github-actions bot added a: text input Entering text in a text field or keyboard related problems platform-windows Building on or for Windows specifically a: desktop Running on desktop labels Aug 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mboetger mboetger mboetger left review comments

@vashworth vashworth vashworth left review comments

@loic-sharma loic-sharma Awaiting requested review from loic-sharma

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
a: desktop Running on desktop a: text input Entering text in a text field or keyboard related problems engine flutter/engine repository. See also e: labels. f: scrolling Viewports, list views, slivers, etc. platform-android Android applications specifically platform-fuchsia Fuchsia code specifically platform-ios iOS applications specifically platform-windows Building on or for Windows specifically team-android Owned by Android platform team team-ios Owned by iOS platform team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LouiseHsu @mboetger @loic-sharma @vashworth