Drawer barrier non dismissible with the escape key #173263
Conversation
…roperty named drawerDismissible
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
…missible"; moved tests topackages/flutter/test/material/drawer_test.dart
…ally_assessments; left the ones there as they were before
…omanejaquez/flutter into drawer_barrier_non_dismissible
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
Co-authored-by: Tong Mu <dkwingsmt@users.noreply.github.com>
…omanejaquez/flutter into drawer_barrier_non_dismissible
Co-authored-by: Justin McCandless <justinjmccandless@gmail.com>
…losed using the escape key if the drawerBarrierDismissible flag is set
There was a problem hiding this comment.
Code Review
This pull request introduces a drawerBarrierDismissible property to Scaffold and DrawerController to control whether the drawer can be dismissed by tapping the scrim or pressing the escape key. The implementation is straightforward, passing the new property down from Scaffold to DrawerController and using it to conditionally enable dismissal gestures. The changes are well-covered by new tests. I have one suggestion to improve the efficiency and readability of the code that handles the escape key dismissal.
c8e6333 to
b06e443
Compare
|
The analyzer is complaining. There were also a lot of unnecessary formatting changes. Can you try |
7ff2f1b to
ec35f07
Compare
|
Also, you may need a merge or rebase in order to fix the ci.yaml validation check. |
d2992f9 to
3700459
Compare
|
Looks like the changes from #164810 are no longer showing up, thank you! But you've got an analyzer failure. |
Additional fix for the 'drawerBarrierDismissible' feature in which the ESC key can close the drawer even if the flag is set to false.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.