Skip to content

Marks Linux android_java17_dependency_smoke_tests to be flaky #172957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Marks Linux android_java17_dependency_smoke_tests to be flaky #172957

wants to merge 1 commit into from
+1 −0

Conversation

fluttergithubbot
Copy link
Contributor

Issue link: #172956

@flutter-dashboard flutter-dashboard bot added c: flake Tests that sometimes, but not always, incorrectly pass c: tech-debt Technical debt, code quality, testing, etc. labels Jul 30, 2025
@github-actions github-actions bot removed the c: tech-debt Technical debt, code quality, testing, etc. label Jul 30, 2025
gemini-code-assist[bot]
gemini-code-assist bot reviewed Jul 30, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly marks the Linux android_java17_dependency_smoke_tests as flaky by adding bringup: true to the CI configuration. The change includes a comment that clearly explains the reason and links to the corresponding GitHub issue for tracking. This is a standard and appropriate way to handle flaky tests to prevent them from blocking the CI pipeline. The change is correct and I have no suggestions for improvement.

@flutter-dashboard
Copy link

This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmackall gmackall Awaiting requested review from gmackall

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
c: flake Tests that sometimes, but not always, incorrectly pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@fluttergithubbot