Fix lock up when window resized with merged UI and platform threads. #172893
+100
−101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the present occurs in the same thread as the draw we need to keep running tasks while we wait for the frame.
|
Warning There is an error in the Gemini Code Assist config file for this repository at |
|
Replaces #172835 |
mattkae
approved these changes
Jul 29, 2025
engine/src/flutter/shell/platform/linux/fl_compositor_software.cc
Outdated
Show resolved
Hide resolved
mattkae
reviewed
Aug 15, 2025
|
|
||
| #include <gdk/gdkwayland.h> | ||
|
|
||
| TEST(FlCompositorSoftwareTest, Render) { | ||
| g_autoptr(FlDartProject) project = fl_dart_project_new(); | ||
| g_autoptr(FlEngine) engine = fl_engine_new(project); | ||
| g_autoptr(FlTaskRunner) task_runner = fl_task_runner_new(engine); |
There was a problem hiding this comment.
Should we also add a test where:
- The initial dimensions are wrong so that it waits on the task runner
- The task runner updates the compositor with the correct dimensions at some point
- The compositor then successfully renders
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the present occurs in the same thread as the draw we need to keep running tasks while we wait for the frame.