Skip to content

Feat: Add carousel view builder #172837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Feat: Add carousel view builder #172837

wants to merge 1 commit into from
+179 −11

Conversation

rkishan516
Copy link
Contributor

Add carousel view builder named constructor
Fixes: #170692

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Jul 28, 2025
@dkwingsmt dkwingsmt requested a review from QuncCccccc July 30, 2025 18:37
QuncCccccc
QuncCccccc reviewed Aug 20, 2025
View reviewed changes
Copy link
Contributor

@QuncCccccc QuncCccccc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of introducing 2 more constructor methods, can we just add itemBuilder to the existing methods?

@rkishan516
Copy link
Contributor Author

Instead of introducing 2 more constructor methods, can we just add itemBuilder to the existing methods?

Yes, that's certainly possible. However, I'd recommend maintaining consistency with the established patterns, as widgets like ListView and PageView follow this same approach. Should we still do this change?

@QuncCccccc
Copy link
Contributor

I see. Then I think this way sounds good to me! I'll take another look today:)!

@QuncCccccc QuncCccccc self-requested a review August 20, 2025 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuncCccccc QuncCccccc Awaiting requested review from QuncCccccc

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CarouselView.builder: Lazy Loading for CarouselView
2 participants
@rkishan516 @QuncCccccc