Skip to content

Remove 'v' Open DevTools from help on web in profile/release mode #172829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Remove 'v' Open DevTools from help on web in profile/release mode #172829

wants to merge 8 commits into from
+66 −6

Conversation

danwirele
Copy link

@danwirele danwirele commented Jul 27, 2025 •
edited
Loading

This change:

  • Hides v from the help menu on web in profile/release mode
  • Keeps v available in debug and on native platforms
  • Change command order: v now appears before s in help
  • Updates _commonTerminalInputHandler to block v on web in release mode

Testing:

  • Added new test: printHelpDetails hides v on web in profile mode
  • Added new test: 'v - does not launchDevToolsInBrowser on web in profile mode'
  • Fixed existing test to match correct command order (v before s)

fixes #143451

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jul 27, 2025
@danwirele
Copy link
Author

@nt4f04uNd hi, can i have a review, please

@nt4f04uNd nt4f04uNd self-assigned this Jul 29, 2025
@nt4f04uNd nt4f04uNd self-requested a review August 3, 2025 21:39
@nt4f04uNd nt4f04uNd removed their assignment Aug 3, 2025
nt4f04uNd
nt4f04uNd reviewed Aug 3, 2025
View reviewed changes
Copy link
Member

@nt4f04uNd nt4f04uNd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @danwirele, welcome here with your first contribution!

It mostly looks good, just small comments about docs here and there.

I am not terribly familiar with the flutter_tools, so I will also seek for one more reviewer to confirm all is good.

It's great that you added multiple tests for this!

nt4f04uNd
nt4f04uNd reviewed Aug 4, 2025
View reviewed changes
@nt4f04uNd nt4f04uNd added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 20, 2025
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 20, 2025
@auto-submit Auto-submit

This comment has been minimized.

Sign in to view
@nt4f04uNd
Copy link
Member

LGTM!

@nt4f04uNd nt4f04uNd added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 21, 2025
@auto-submit Auto-submit

This comment has been minimized.

Sign in to view
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nt4f04uNd nt4f04uNd nt4f04uNd approved these changes

Assignees
No one assigned
Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hide v open devtools option when running profile & release mode in Flutter Web
2 participants
@danwirele @nt4f04uNd