Skip to content

Remove emoji from ci.yaml, because we still live with CP1252 for some silly reason #172256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2025

Conversation

jtmcdole
Copy link
Member

WARNING: codefu's snark level is approaching maximums.

… silly reason

WARNING: codefu's snark level is approaching maximums.
@jtmcdole jtmcdole requested a review from matanlurey July 16, 2025 21:33
@github-actions github-actions bot added the engine flutter/engine repository. See also e: labels. label Jul 16, 2025
@jtmcdole jtmcdole added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 16, 2025
@jtmcdole jtmcdole marked this pull request as draft July 16, 2025 21:38
@jtmcdole jtmcdole removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 16, 2025
@jtmcdole jtmcdole marked this pull request as ready for review July 16, 2025 21:41
@jtmcdole jtmcdole added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 16, 2025
@jtmcdole
Copy link
Member Author

Byte 735 is not the emoji, but the error reported is so deep in yaml parsing, I'm going to assume that's it.

@auto-submit auto-submit bot added this pull request to the merge queue Jul 16, 2025
@matanlurey matanlurey added the cp: beta cherry pick this pull request to beta release candidate branch label Jul 16, 2025
Merged via the queue into master with commit 318a228 Jul 16, 2025
186 of 187 checks passed
@auto-submit auto-submit bot deleted the CP1252-patch-1 branch July 16, 2025 23:09
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 16, 2025
@matanlurey matanlurey added cp: beta cherry pick this pull request to beta release candidate branch and removed cp: beta cherry pick this pull request to beta release candidate branch labels Jul 16, 2025
flutteractionsbot pushed a commit to flutteractionsbot/flutter that referenced this pull request Jul 16, 2025
… silly reason (flutter#172256)

WARNING: codefu's snark level is approaching maximums.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2025
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jul 17, 2025
flutter/flutter@c2739f0...9c626d9

2025-07-17 engine-flutter-autoroll@skia.org Roll Skia from 5b4afa58289a to 3673a1f26a63 (1 revision) (flutter/flutter#172274)
2025-07-17 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from JRFUXSNXExcfjVYvA... to HXdm7P0a4ZJVm_TE-... (flutter/flutter#172268)
2025-07-17 engine-flutter-autoroll@skia.org Roll Dart SDK from d71df90177e4 to 486f9c0663bc (1 revision) (flutter/flutter#172269)
2025-07-17 engine-flutter-autoroll@skia.org Roll Skia from 3ad1aace3e02 to 5b4afa58289a (3 revisions) (flutter/flutter#172264)
2025-07-17 robert.ancell@canonical.com Perform OpenGL compositing in the Flutter thread and write to a framebuffer. (flutter/flutter#172090)
2025-07-17 30870216+gaaclarke@users.noreply.github.com Licenses cpp 716 (flutter/flutter#172261)
2025-07-16 codefu@google.com Remove emoji from ci.yaml, because we still live with CP1252 for some silly reason (flutter/flutter#172256)
2025-07-16 engine-flutter-autoroll@skia.org Roll Skia from bf3f9b77d3a8 to 3ad1aace3e02 (11 revisions) (flutter/flutter#172255)
2025-07-16 matanlurey@users.noreply.github.com Sync `CHANGELOG.md` (3.32.7) to `master` branch (flutter/flutter#172253)
2025-07-16 1961493+harryterkelsen@users.noreply.github.com Properly lay out and position RenderWebImage (flutter/flutter#171916)
2025-07-16 chinmaygarde@google.com Remove dead link in the doc index. (flutter/flutter#172240)
2025-07-16 engine-flutter-autoroll@skia.org Roll Dart SDK from 766ee8029b11 to d71df90177e4 (1 revision) (flutter/flutter#172243)
2025-07-16 matanlurey@users.noreply.github.com Fix use of `Join-Path` in `last_engine_commit.ps1`(poweshell) (flutter/flutter#172242)
2025-07-16 fluttergithubbot@gmail.com Marks Linux_pixel_7pro integration_ui_driver to be unflaky (flutter/flutter#172213)
2025-07-16 jacksongardner@google.com [skwasm] Decrease reliance on finalizers/GC (flutter/flutter#172187)
2025-07-16 matanlurey@users.noreply.github.com Use `release-*.version` to simplify `last_engine_commit.sh` (no branch operations) (flutter/flutter#172236)
2025-07-16 engine-flutter-autoroll@skia.org Roll Skia from 59be8479c637 to bf3f9b77d3a8 (7 revisions) (flutter/flutter#172233)
2025-07-16 sokolovskyi.konstantin@gmail.com [web] Remove all usages of js_util. (flutter/flutter#171871)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
azatech pushed a commit to azatech/flutter that referenced this pull request Jul 28, 2025
… silly reason (flutter#172256)

WARNING: codefu's snark level is approaching maximums.
vashworth pushed a commit to vashworth/packages that referenced this pull request Jul 30, 2025
…r#9641)

flutter/flutter@c2739f0...9c626d9

2025-07-17 engine-flutter-autoroll@skia.org Roll Skia from 5b4afa58289a to 3673a1f26a63 (1 revision) (flutter/flutter#172274)
2025-07-17 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from JRFUXSNXExcfjVYvA... to HXdm7P0a4ZJVm_TE-... (flutter/flutter#172268)
2025-07-17 engine-flutter-autoroll@skia.org Roll Dart SDK from d71df90177e4 to 486f9c0663bc (1 revision) (flutter/flutter#172269)
2025-07-17 engine-flutter-autoroll@skia.org Roll Skia from 3ad1aace3e02 to 5b4afa58289a (3 revisions) (flutter/flutter#172264)
2025-07-17 robert.ancell@canonical.com Perform OpenGL compositing in the Flutter thread and write to a framebuffer. (flutter/flutter#172090)
2025-07-17 30870216+gaaclarke@users.noreply.github.com Licenses cpp 716 (flutter/flutter#172261)
2025-07-16 codefu@google.com Remove emoji from ci.yaml, because we still live with CP1252 for some silly reason (flutter/flutter#172256)
2025-07-16 engine-flutter-autoroll@skia.org Roll Skia from bf3f9b77d3a8 to 3ad1aace3e02 (11 revisions) (flutter/flutter#172255)
2025-07-16 matanlurey@users.noreply.github.com Sync `CHANGELOG.md` (3.32.7) to `master` branch (flutter/flutter#172253)
2025-07-16 1961493+harryterkelsen@users.noreply.github.com Properly lay out and position RenderWebImage (flutter/flutter#171916)
2025-07-16 chinmaygarde@google.com Remove dead link in the doc index. (flutter/flutter#172240)
2025-07-16 engine-flutter-autoroll@skia.org Roll Dart SDK from 766ee8029b11 to d71df90177e4 (1 revision) (flutter/flutter#172243)
2025-07-16 matanlurey@users.noreply.github.com Fix use of `Join-Path` in `last_engine_commit.ps1`(poweshell) (flutter/flutter#172242)
2025-07-16 fluttergithubbot@gmail.com Marks Linux_pixel_7pro integration_ui_driver to be unflaky (flutter/flutter#172213)
2025-07-16 jacksongardner@google.com [skwasm] Decrease reliance on finalizers/GC (flutter/flutter#172187)
2025-07-16 matanlurey@users.noreply.github.com Use `release-*.version` to simplify `last_engine_commit.sh` (no branch operations) (flutter/flutter#172236)
2025-07-16 engine-flutter-autoroll@skia.org Roll Skia from 59be8479c637 to bf3f9b77d3a8 (7 revisions) (flutter/flutter#172233)
2025-07-16 sokolovskyi.konstantin@gmail.com [web] Remove all usages of js_util. (flutter/flutter#171871)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
ksokolovskyi pushed a commit to ksokolovskyi/flutter that referenced this pull request Aug 19, 2025
… silly reason (flutter#172256)

WARNING: codefu's snark level is approaching maximums.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cp: beta cherry pick this pull request to beta release candidate branch engine flutter/engine repository. See also e: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants