[iOS][Secure Paste] Custom edit menu actions #171825

jingshao-code · 2025-07-08T22:25:02Z

This PR implements support for custom action items in the native edit menu on iOS, with changes to both framework and engine. This PR will be updated incrementally until the full feature is complete.

Phase 1: Add hardcoded custom menu item for iOS edit menu.
Phase 2: Add Framework API for custom iOS context menu items.
Phase 3: Add Optimization, Testing, and Documentation.

Part of #103163

Part of #140184

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

hellohuanlin · 2025-07-09T17:59:03Z

engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterEngine.mm

+- (void)flutterTextInputView:(FlutterTextInputView*)textInputView
+         performCustomAction:(NSString*)customAction
+                  withClient:(int)client {
+  [self.textInputChannel invokeMethod:@"TextInputClient.performCustomAction"


can you use platformChannel and ContextMenu prefix? (similar to willDismissEditMenuWithTextInputClient method in this file)

Thanks for reviewing! I've implemented all your suggestions, but I have a question about the method naming: The current method name is quite long. Would you prefer to keep it as is for clarity, or should we consider simplifying it? For example: performContextMenuCustomAction?

hellohuanlin · 2025-07-09T17:59:28Z

engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterEngine.mm

+         performCustomAction:(NSString*)customAction
+                  withClient:(int)client {
+  [self.textInputChannel invokeMethod:@"TextInputClient.performCustomAction"
+                             arguments:@[ @(client), customAction ]];


is the customAction the ID? if so you should call it customActionID

hellohuanlin · 2025-07-09T18:00:46Z

engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterTextInputPlugin.mm

+      if (customId && title) {
+        UIAction* action = [UIAction actionWithTitle:title
+                                               image:nil
+                                          identifier:customId


no need to set identifier.

hellohuanlin · 2025-07-09T18:01:28Z

engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterTextInputPlugin.mm

+                                               image:nil
+                                          identifier:customId
+                                             handler:^(__kindof UIAction* _Nonnull action) {
+          [self.textInputDelegate flutterTextInputView:self


need to use weak self

hellohuanlin · 2025-07-09T18:02:53Z

The engine part is heading the right direction. Good work!

justinmc

Overall this approach looks solid! Most of my comments are just about how we organize the code.

I left one comment about adding an example to the examples directory. I think that will help us to visualize how this will work better, and it will allow you to remove your debug code for the vibrate button.

I also left a comment about the callback map not being cleared when the system hides the menu. I'll keep an eye out for other sources of leaks. We'll have to make sure that we cover use cases like showing one SystemContextMenu widget, then immediately showing another. I think hide might get called in that case so we'll be covered, but we should make sure.

justinmc · 2025-07-16T17:00:47Z

packages/flutter/lib/src/services/text_input.dart

+    if (callback != null) {
+      callback();
+      return;
+    }


Can you also assert that the callback is not null so that developers can be aware that something is wrong?

Not sure if this is testable or not, but it would be nice if we can test it.

justinmc · 2025-07-16T17:02:40Z

packages/flutter/lib/src/services/text_input.dart

+    if (actionId == 'vibrate') {
+      debugPrint('[HARDCODED] Vibrate action triggered');
+      return;
+    }


Can you write an example in the examples/api/lib directory that does something like this at the user level? Maybe a more complex version of this one: https://github.com/flutter/flutter/blob/master/examples/api/lib/widgets/system_context_menu/system_context_menu.0.dart

Maybe put your example on the items parameter of SystemContextMenu:

flutter/packages/flutter/lib/src/widgets/system_context_menu.dart

Line 103 in 323b45e

final List<IOSSystemContextMenuItem> items;

justinmc · 2025-07-16T17:04:21Z

packages/flutter/lib/src/services/text_input.dart

@@ -2118,6 +2135,9 @@ class TextInput {
          firstArg['action'] as String,
          firstArg['data'] == null ? <String, dynamic>{} : firstArg['data'] as Map<String, dynamic>,
        );
+      case 'TextInputClient.performCustomAction':


Maybe this should go in services/binding.dart, where we handle onDismissSystemContextMenu.

justinmc · 2025-07-16T17:06:36Z

packages/flutter/lib/src/services/text_input.dart

@@ -2624,6 +2644,9 @@ class SystemContextMenuController with SystemContextMenuClient, Diagnosticable {

  static SystemContextMenuController? _lastShown;

+  /// Map to store custom action callbacks, keyed by their unique identifiers.
+  static final Map<String, VoidCallback> _customActionCallbacks = <String, VoidCallback>{};


If the method channel call were handled in binding.dart, then you could handle this stuff via SystemContextMenuClient and SystemContextMenuController.

justinmc · 2025-07-16T17:15:21Z

packages/flutter/lib/src/services/text_input.dart

@@ -2809,6 +2853,7 @@ class SystemContextMenuController with SystemContextMenuClient, Diagnosticable {
    }
    _lastShown = null;
    ServicesBinding.systemContextMenuClient = null;
+    _clearCustomActions();


I think this should also get cleared when the platform hides the context menu (ContextMenu.onDismissSystemContextMenu).

This is how the platform hides it:

flutter/packages/flutter/lib/src/services/binding.dart

Line 415 in 323b45e

case 'ContextMenu.onDismissSystemContextMenu':

justinmc · 2025-07-16T17:17:21Z

packages/flutter/lib/src/widgets/system_context_menu.dart

+  @override
+  IOSSystemContextMenuItemData getData(WidgetsLocalizations localizations) {
+    final String callbackId = '${DateTime.now().millisecondsSinceEpoch}_${title.hashCode}';
+    SystemContextMenuController.registerCustomAction(callbackId, onPressed);


This is a tricky side effect that developers probably won't expect when calling getData. See https://github.com/flutter/flutter/blob/master/docs/contributing/Style-guide-for-Flutter-repo.md#getters-feel-faster-than-methods

Could you register these when the system context menu is shown?

I think this should hopefully sort itself out when you move the action map to SystemContextMenuController, as mentioned above. So I would do that first before trying to address this comment.

justinmc · 2025-07-16T17:24:58Z

packages/flutter/lib/src/widgets/system_context_menu.dart

+
+  @override
+  IOSSystemContextMenuItemData getData(WidgetsLocalizations localizations) {
+    final String callbackId = '${DateTime.now().millisecondsSinceEpoch}_${title.hashCode}';


I think just hashCode is probably a good key for this. The only possible collision would be for the exact same item with the exact same onPressed, say if you passed the same item into the items List twice. Even in that case, it would be fine to have only one entry in the _customActionCallbacks map and to call the same one for both.

Also IOSSystemContextMenuItemCustom is const, so this is equivalent to passing the same instance:

items: <IOSSystemContextMenuItem>[ IOSSystemContextMenuItemCustom(title: 'press me', onPressed: _myOnPressed), IOSSystemContextMenuItemCustom(title: 'press me', onPressed: _myOnPressed), ],

But even in that case, it's fine to have only one entry in _customActionCallbacks.

Hi Justin, I have made all the changes based on your comments and we discussed last time:

Moved callbacks from static to instance-based

Now routes through binding.dart

getData() now only returns data, side-effect free

Added proper cleanup when platform dismisses the menu

Removed the hardcoded testa

Added the tests and a working example

Looking forward to your feedback!

justinmc

This is looking good, thanks for doing that refactor. I think putting the callback map inside of SystemContextMenuController is much better now. Also the example is great.

justinmc · 2025-07-22T17:55:57Z

examples/api/lib/widgets/system_context_menu/system_context_menu.1.dart

+                  _controller.text = text.replaceRange(
+                    selection.start,
+                    selection.end,
+                    '❤️',
+                  );
+                  _controller.selection = TextSelection.collapsed(
+                    offset: selection.start + 2,
+                  );


Nit: I would do this as a single update by setting _controller.value.

justinmc · 2025-07-22T17:58:36Z

examples/api/test/widgets/system_context_menu/system_context_menu.1_test.dart

+      expect(controller.text, '');
+      expect(find.text('Text cleared'), findsOneWidget);
+    },
+    skip: defaultTargetPlatform != TargetPlatform.iOS || kIsWeb, // [intended]


Rather than skipping for the platform, use variant and TargetPlatformVariant.only. Skipping for kIsWeb is ok.

justinmc · 2025-07-22T18:01:52Z

examples/api/lib/widgets/system_context_menu/system_context_menu.1.dart

This is a great example, thanks for adding it.

justinmc · 2025-07-22T18:13:22Z

packages/flutter/lib/src/services/text_input.dart

@@ -2770,9 +2783,18 @@ class SystemContextMenuController with SystemContextMenuClient, Diagnosticable {

    ServicesBinding.systemContextMenuClient = this;

+    _customActionCallbacks.clear();


I think you also might need to call this in handleSystemHide. Then I think we will be covered and this shouldn't leak.

Also test this: Show the SystemContextMenu with a certain item, then show again with a new item. Then try sending a handleCustomContextMenuAction for the original item.

justinmc · 2025-07-22T18:15:16Z

packages/flutter/lib/src/services/text_input.dart

+
+    for (final IOSSystemContextMenuItemData item in items) {
+      if (item is IOSSystemContextMenuItemDataCustom) {
+        _customActionCallbacks[item.callbackId] = item.onPressed;


What do you think, would it be worth it to assert that there are no duplicate item.callbackIds? I guess it's not a problem for us if there are, and maybe users have a real reason to do something like that.

Maybe assert if there are duplicate callbackIds AND the callbacks are not equivalent? That seems like it would very likely be a mistake on the part of the app developer.

Making a note that we talked this over offline and seemed to agree on the comment above this one.

justinmc · 2025-07-22T18:17:14Z

packages/flutter/lib/src/services/text_input.dart

+      'callbackId': callbackId,
+      'title': title,
+      'type': _jsonType,
+      'id': callbackId,


Do you need both an id and a callbackId?

justinmc · 2025-07-22T18:17:43Z

packages/flutter/lib/src/services/text_input.dart

+    return other is IOSSystemContextMenuItemDataCustom &&
+        other.title == title &&
+        other.callbackId == callbackId;


onPressed should probably also be included here.

Also should include onPressed in hashCode (discussed offline).

justinmc · 2025-07-22T18:18:57Z

packages/flutter/lib/src/widgets/system_context_menu.dart

+  IOSSystemContextMenuItemData getData(WidgetsLocalizations localizations) {
+    return IOSSystemContextMenuItemDataCustom(
+      title: title,
+      callbackId: hashCode.toString(),


Instead of passing the callbackId in here, could IOSSystemContextMenuItemData generate it itself?

justinmc · 2025-07-22T18:30:22Z

packages/flutter/test/widgets/system_context_menu_test.dart

+      final IOSSystemContextMenuItemCustom customItem1 = items[1] as IOSSystemContextMenuItemCustom;
+      final IOSSystemContextMenuItemCustom customItem2 = items[2] as IOSSystemContextMenuItemCustom;
+
+      controller2.handleCustomContextMenuAction(customItem1.hashCode.toString());


Can you also test that a call from onPerformCustomAction works? You can simulate the platform message using TestDefaultBinaryMessengerBinding.instance.defaultBinaryMessenger.handlePlatformMessage.

No need to use handlePlatformMessage every time, it's also fine to use handleCustomContextMenuAction directly like you are here. Just make sure that the onPerformCustomAction gets tested at least once too.

Also try the error state: send that message when there is no _systemContextMenuClient.

I've added the platform channel test as requested. Note: I had to use handlePlatformMessage for all tests (not just one) because SystemContextMenu doesn't expose its controller, it's created internally in
_SystemContextMenuState and not accessible from tests. Is this the correct approach, or did you have a different testing strategy in mind?

justinmc · 2025-07-22T18:41:13Z

packages/flutter/lib/src/widgets/system_context_menu.dart

+/// {@tool dartpad}
+/// This example shows how to add custom menu items to the iOS system context menu.
+///
+/// ** See code in examples/api/lib/widgets/system_context_menu/system_context_menu.1.dart **
+/// {@end-tool}


Do you think it would be valuable to also add this example to SystemContextMenu.items, or is it too much?

justinmc · 2025-07-28T22:24:00Z

packages/flutter/test/widgets/system_context_menu_test.dart

+      expect(customAction1Called, isTrue);
+      expect(customAction2Called, isFalse);
+
+      controller2.handleCustomContextMenuAction(customItem2.hashCode.toString());


Another test idea: What happens when you call handleCustomContextMenuAction after the menu has been hidden?

What happens when it's called with a callbackId that doesn't exist?

Probably put those tests in system_context_menu_controller_test.dart.

jingshao-code · 2025-08-04T17:51:30Z

Justin, Thanks for the meeting! I've made all the changes：

Switched to atomic updates with _controller.value
Made callback ID generation internal (much cleaner now!)
Confirmed memory cleanup in both hide() and handleSystemHide()
Removed the duplicate id/callbackId
Fixed hashCode/equality to include onPressed
Added assertions for duplicate IDs
Updated test variants
Added all the edge case tests you suggested

Looking forward to your feedback!

justinmc

I had a question about whether the menu auto-closes when a button is pressed or not that came up in a few comments below.

justinmc · 2025-08-04T18:51:13Z

examples/api/test/widgets/system_context_menu/system_context_menu.1_test.dart

+      await tester.pumpAndSettle();
+
+      if (defaultTargetPlatform == TargetPlatform.iOS) {
+        expect(find.byType(SystemContextMenu), findsOneWidget);


Nit: Can you also check: expect(find.byType(AdaptiveTextSelectionToolbar), findsNothing);?

justinmc · 2025-08-04T18:59:17Z

packages/flutter/lib/src/services/binding.dart

+        if (_systemContextMenuClient == null) {
+          assert(
+            false,
+            'Platform sent onPerformCustomAction when no SystemContextMenuClient was registered.',


Nit: Maybe add some actionable advice here like this? "ServicesBinding.systemContextMenuCilent shouldn't be cleared unless the menu is hidden."

I'm not sure how helpful that is for app developers, but this assert is such a weird case, not sure if there's a better option. Up to you if you want to include something like this or leave it as-is.

justinmc · 2025-08-04T19:48:53Z

packages/flutter/lib/src/services/text_input.dart

-// https://github.com/flutter/flutter/issues/103163
+/// An [IOSSystemContextMenuItemData] for custom action buttons defined by the developer.
+///
+/// Must specify a [title] and [callbackId].


Should say title and onPressed.

justinmc · 2025-08-04T19:50:18Z

packages/flutter/lib/src/services/text_input.dart

+  final VoidCallback onPressed;
+
+  /// The unique identifier for this custom action.
+  String get callbackId => hashCode.toString();


Nit: It would be possible to cache this to avoid recomputing it each time. Do you think it's worth it?

IMO, I think hashCode.toString() is basically free, and each instance's hashCode is already stable throughout its lifetime, not worth the extra code

I'm on board with that 👍

Nit: Did you think about making callbackId an int instead of a String? I think a String makes sense to me, just wanted to make sure you thought through it.

justinmc · 2025-08-04T19:54:30Z

packages/flutter/lib/src/services/binding.dart

+        final String actionId = args[1] as String;
+        _systemContextMenuClient!.handleCustomContextMenuAction(actionId);


Nit: I would call this callbackId here and in the parameter name of handleCustomContextMenuAction. The reason is just to keep the name always the same, because callbackId is used elsewhere in this PR.

justinmc · 2025-08-04T20:06:54Z

examples/api/test/widgets/system_context_menu/system_context_menu.1_test.dart

+      await tester.pumpAndSettle();
+
+      expect(controller.text, '');
+      expect(find.text('Text cleared'), findsOneWidget);


Can you also check whether the SystemContextMenu is still visible or not? I assume the answer is no, it hides itself? If not the we should show how to do that in the example, but I think it does hide.

justinmc · 2025-08-04T20:08:10Z

packages/flutter/test/widgets/system_context_menu_test.dart

+        (_) {},
+      );
+
+      expect(customActionCalled, isTrue);


Also expect SystemContextMenu is hidden here (assuming that's true).

justinmc · 2025-08-04T20:09:20Z

packages/flutter/test/widgets/system_context_menu_test.dart

+      );
+      expect(customAction2Called, isTrue);
+
+      state.hideToolbar();


Do you have to manually call hide or does it automatically hide?

I have tested on my iPhone - it does auto-close. But I think in tests maybe we need to fake it with hideToolbar().

justinmc · 2025-08-04T20:09:39Z

packages/flutter/test/widgets/system_context_menu_test.dart

+  testWidgets(
+    'can trigger custom menu action through platform channel message',


Does this test cover any code paths that the previous test does not?

If not you could consider deleting it, but it's up to you if this is valuable or not.

I kept it finally, I think tests mixed items scenario (Cut + custom), which is different from the pure custom test.

justinmc · 2025-08-04T20:11:26Z

packages/flutter/test/widgets/system_context_menu_test.dart

+    },
+    skip: kIsWeb, // [intended]
+    variant: TargetPlatformVariant.only(TargetPlatform.iOS),
+  );


One more test I think we should add for completeness: Pump an app with two TextFields, each with their own custom SystemContextMenu item. Open the context menu in one field, expect that only its custom button was shown, tap it, expect that its callback was called. Then do the same for the other field.

jingshao-code · 2025-08-11T12:35:04Z

Justin, Thanks for the meeting! I've made all the changes：

Fixed naming
Added tests for menu auto-close and two TextFields
Fixed docs to say "title and onPressed"
Added missing periods
Decided against caching (hashCode.toString() is cheap)

Note: Device testing confirmed iOS menus do auto-close after custom actions. Tests simulate this with hideToolbar().

Looking forward to your feedback!

justinmc

LGTM with nits 👍 . Great work!

justinmc · 2025-08-11T20:02:51Z

packages/flutter/lib/src/services/text_input.dart

+  final VoidCallback onPressed;
+
+  /// The unique identifier for this custom action.
+  String get callbackId => hashCode.toString();


I'm on board with that 👍

justinmc · 2025-08-11T20:20:43Z

packages/flutter/test/widgets/system_context_menu_test.dart

+      // iOS system menus auto-close after custom actions on real devices,
+      // but in tests we need to manually call hideToolbar() to simulate this.
+      state.hideToolbar();


Instead of calling hideToolbar would it be possible to send the ContextMenu.onDismissSystemContextMenu platform channel message in order to make this more realistic?

justinmc · 2025-08-11T20:24:00Z

packages/flutter/test/widgets/system_context_menu_test.dart

+      expect(field2ActionCalled, isTrue);
+
+      state2.hideToolbar();
+      await tester.pump();


Nit: Maybe do a final expect that SystemContextMenu is not found. Ending on a pump makes me wonder what was being tested there.

justinmc · 2025-08-11T20:25:40Z

packages/flutter/lib/src/services/text_input.dart

+  final VoidCallback onPressed;
+
+  /// The unique identifier for this custom action.
+  String get callbackId => hashCode.toString();


Nit: Did you think about making callbackId an int instead of a String? I think a String makes sense to me, just wanted to make sure you thought through it.

justinmc · 2025-08-11T20:27:31Z

engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterTextInputPlugin.mm

@@ -1003,6 +1004,24 @@ - (UIMenu*)editMenuInteraction:(UIEditMenuInteraction*)interaction
                                   selector:@selector(captureTextFromCamera:)
                              suggestedMenu:suggestedMenu];
      }
+    } else if ([type isEqualToString:@"custom"]) {
+      NSString* customId = encodedItem[@"id"];


Nit: Have you thought about naming this parameter callbackId just so it has the same name as it does in the framework? I'm not sure which name is better, just wanted to call it out.

hellohuanlin · 2025-08-21T17:34:10Z

engine/src/flutter/shell/platform/darwin/ios/framework/Source/FlutterTextInputPluginTest.mm

          [mockPlatformChannel invokeMethod:@"ContextMenu.onPerformCustomAction"
                                  arguments:@[ @(123), @"test-callback-id" ]];
-        });
+        }));


this shouldn't be required. can you revert?

This change fixes a CI compilation error:

FlutterTextInputPluginTest.mm:3926:56: error: too many arguments provided to function-like macro invocation ../flutter/third_party/ocmock/Source/OCMock/OCMStubRecorder.h:55:9: note: macro 'andDo' defined here

So I added the parentheses to prevent OCMock's andDo macro from misinterpreting the comma in @[ @(123), @"test-callback-id"] as a macro argument separator.

Hmmm, this is strange. Searching through the code, we do have both .andDo(( and .andDo(, so andDo(( shouldn't be necessary. Nvm, i guess sometimes the compiler needs extra hint.

Thanks! Yes, the comma in array literals specifically triggers this issue.
https://gcc.gnu.org/onlinedocs/cpp/Macro-Arguments.html
This mentions the behavior: "Parentheses within each argument must balance; a comma within such parentheses does not end the argument."

justinmc

LGTM with nits 👍

I also had a comment about renaming "id" to "callbackId", did you intend to do that or decide to leave it? #171825 (comment)

justinmc · 2025-08-21T21:58:29Z

packages/flutter/test/widgets/system_context_menu_test.dart

@@ -889,10 +889,452 @@ void main() {
      await tester.tap(find.byType(TextField));
      final EditableTextState state = tester.state<EditableTextState>(find.byType(EditableText));
      expect(state.showToolbar(), true);
-      await tester.pump();
+      await tester.pumpAndSettle();


Can this stay as pump or is it necessary for some reason?

I think you're right! I initially used pumpAndSettle() when debugging some test failures, thinking the menu might need more time to appear. I've changed it back to pump(), and the widgets tests passed (I remember before the current infrastructure issues). The earlier failures were likely due to other issues in the test setup that have since been fixed.

@justinmc The CI is failing with SDK download 404 errors. I've tried reverting to previous passing commits and rebasing to the latest master, but still getting the same infrastructure error. Any suggestions on how to proceed?

jingshao-code · 2025-08-22T05:28:53Z

LGTM with nits 👍

I also had a comment about renaming "id" to "callbackId", did you intend to do that or decide to leave it? #171825 (comment)

Sorry, I missed replying to this.

I've renamed the variable customId to callbackId to match the framework's property name.

I kept the JSON key as "id", which both framework and engine use for communication. I think this follows the convention where "id" is a standard identifier field, and matches Flutter's existing patterns (like {'id': viewId} in platform views).

That's my thought. Happy to do that if you think it's worth the consistency!

…e, nil identifier, weak self

- Add IOSSystemContextMenuItemCustom widget class - Add IOSSystemContextMenuItemDataCustom data class - Implement callback registration and management - Support both API and hardcoded test callbacks

- Instance-based callback management in SystemContextMenuController - Route custom actions through platform channel via binding.dart - Clear callbacks on hide() and handleSystemHide() - Remove getData() side effects, use hashCode for IDs - Add example (system_context_menu.1.dart) and tests

- Use atomic text editing value updates - Make callback ID generation internal to IOSSystemContextMenuItemDataCustom - Simplify JSON output to use single ID field - Fix hashCode and equality to include onPressed callback - Add assertion for duplicate callback IDs - Update tests to use TargetPlatformVariant - Add platform channel integration test - Add edge case tests for error scenarios - Add documentation example for custom menu items

- Verify iOS system menu auto-closes after custom action via device testing - Change actionId to callbackId throughout for consistency - Add test for menu auto-close behavior after custom action - Add test for two TextFields with different custom menus - Fix documentation to say 'title and onPressed' instead of 'title and callbackId' - Add AdaptiveTextSelectionToolbar check in example test - Improve error message in ServicesBinding with actionable advice - Add missing periods to comments

…age in tests - Add final expect verification in two TextFields test - Rename customId to callbackId in engine for consistency

- Rename delegate method to performContextMenuCustomActionWithActionID:textInputClient: - Add 2 native-side unit tests for custom menu functionality

…yle fixes to pass CI checks

Add custom type support to systemContextMenuItemDataFromJson with fake callback

jingshao-code requested review from justinmc and hellohuanlin July 8, 2025 22:29

hellohuanlin reviewed Jul 9, 2025

View reviewed changes

jingshao-code requested a review from hellohuanlin July 14, 2025 09:40

jingshao-code force-pushed the ios-custom-menu branch from a8fc6d0 to 1237713 Compare July 14, 2025 11:21

justinmc reviewed Jul 16, 2025

View reviewed changes

github-actions bot added d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos labels Jul 22, 2025

jingshao-code force-pushed the ios-custom-menu branch from 2d84e34 to 305c513 Compare July 22, 2025 09:51

jingshao-code requested a review from justinmc July 22, 2025 10:07

justinmc reviewed Jul 22, 2025

View reviewed changes

justinmc reviewed Jul 28, 2025

View reviewed changes

jingshao-code requested a review from justinmc August 4, 2025 17:17

justinmc reviewed Aug 4, 2025

View reviewed changes

jingshao-code requested a review from justinmc August 11, 2025 12:35

justinmc approved these changes Aug 11, 2025

View reviewed changes

justinmc reviewed Aug 11, 2025

View reviewed changes

jingshao-code marked this pull request as ready for review August 11, 2025 22:19

jingshao-code requested a review from a team as a code owner August 11, 2025 22:19

jingshao-code requested review from justinmc and hellohuanlin August 21, 2025 15:12

hellohuanlin reviewed Aug 21, 2025

View reviewed changes

justinmc approved these changes Aug 21, 2025

View reviewed changes

jingshao-code force-pushed the ios-custom-menu branch from d6049f1 to ed744b9 Compare August 22, 2025 12:56

flutter deleted a comment from fluttergithubbot Aug 22, 2025

jingshao-code added 22 commits August 22, 2025 22:06

[iOS] Phase 1: Add hardcoded custom menu item for iOS edit menu

ba9359b

[iOS] Address custom menu PR feedback: method naming, parameter renam…

50e3b48

…e, nil identifier, weak self

Implement Phase 2: Framework API for custom context menu items

f49961f

- Add IOSSystemContextMenuItemCustom widget class - Add IOSSystemContextMenuItemDataCustom data class - Implement callback registration and management - Support both API and hardcoded test callbacks

resolve conflicts

6d08282

- Replace hideToolbar() with onDismissSystemContextMenu platform mess…

687cbb6

…age in tests - Add final expect verification in two TextFields test - Rename customId to callbackId in engine for consistency

Rename delegate method and add native tests

ffe6a11

- Rename delegate method to performContextMenuCustomActionWithActionID:textInputClient: - Add 2 native-side unit tests for custom menu functionality

Fix framework-side issues for CI. No functional changes, only code st…

dfc23ee

…yle fixes to pass CI checks

Fix formatting issues in framework-side

b9d2171

Fix method name and arguments in context menu tests

753b023

Fix test codec and multiple controllers logic

70f9eb7

Fix test: Add platform dismiss message for iOS menu auto-close

0d5c8f2

Retry CI

f116bb1

Fix CI test failures in system context menu

6fc8af8

Add custom type support to systemContextMenuItemDataFromJson with fake callback

Fix formatting and custom menu action test

f394a84

Fix custom menu test formatting and remove redundant mock

666ae42

Fix custom menu test mock setup

e5e07a4

Fix OCMock andDo macro compilation error

c3d213c

test

4ba9db4

Trigger Build

8fb0e6d

jingshao-code force-pushed the ios-custom-menu branch from b35d962 to 8fb0e6d Compare August 22, 2025 14:07

		@@ -2770,9 +2783,18 @@ class SystemContextMenuController with SystemContextMenuClient, Diagnosticable {

		ServicesBinding.systemContextMenuClient = this;

		_customActionCallbacks.clear();

		final String actionId = args[1] as String;
		_systemContextMenuClient!.handleCustomContextMenuAction(actionId);

		testWidgets(
		'can trigger custom menu action through platform channel message',

[iOS][Secure Paste] Custom edit menu actions #171825

Are you sure you want to change the base?

[iOS][Secure Paste] Custom edit menu actions #171825

Conversation

jingshao-code commented Jul 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hellohuanlin commented Jul 9, 2025

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jingshao-code commented Jul 8, 2025 •

edited

Loading

jingshao-code Aug 4, 2025 •

edited

Loading

jingshao-code commented Aug 4, 2025 •

edited

Loading