synchronously flush semantics when semantics is enabled #170014
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
|
I am pretty sure something will be broken, just that we don't have good semantics test coverage on this part. will add more test. @jonahwilliams would like to get your opinion first to see if this is something we should do |
| @@ -1389,6 +1389,7 @@ base class PipelineOwner with DiagnosticableTreeMixin { | |||
| ); | |||
| _semanticsOwner = SemanticsOwner(onSemanticsUpdate: onSemanticsUpdate!); | |||
| onSemanticsOwnerCreated?.call(); | |||
| flushSemantics(); | |||
There was a problem hiding this comment.
all embedding including our desktop has a trigger in the accessibility bridge to enable semantics when os query the a11y tree. For platform that has merged thread, that trigger will call this method synchronously.
This method creates semantics tree and sends update to embedding synchronously.
|
Sorry I missed this completely. I'm not certain why we wouldn't do this, though I admit I haven't looked at this code in a while |
Agree, will ping again after appropriate tests are added |
|
@chunhtai Do you need a new reviewer here? |
|
This is not yet ready, I will try to get to this pr soon |
This is an attempt to reduce initial data delay when android or iOS tries to query semantics tree.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.