Skip to content

[framework] re-enable skipped impeller goldens. #166354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Apr 9, 2025
Merged

[framework] re-enable skipped impeller goldens. #166354

merged 9 commits into from
Apr 9, 2025

Conversation

jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented Apr 1, 2025 •
edited
Loading

Fixes #143616

Maybe. Lets see if its stable.

Update: I've run this a few times and it seems stable.

@github-actions github-actions bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. f: cupertino flutter/packages/flutter/cupertino repository labels Apr 1, 2025
@flutter-dashboard
Copy link

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #166354 at sha 3e4a378

@flutter-dashboard flutter-dashboard bot added the will affect goldens Changes to golden files label Apr 2, 2025
@jonahwilliams jonahwilliams requested a review from matanlurey April 8, 2025 18:05
@jonahwilliams jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 9, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Apr 9, 2025
Merged via the queue into flutter:master with commit 22bcb9d Apr 9, 2025
75 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 9, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 9, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 9, 2025
@engine-flutter-autoroll
22bcb9d5e [framework] re-enable skipped impeller goldens. (flutter/fl…
61140d6 
…utter#166354)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 9, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 9, 2025
@engine-flutter-autoroll
22bcb9d5e [framework] re-enable skipped impeller goldens. (flutter/fl…
0e3999e 
…utter#166354)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 9, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 9, 2025
@engine-flutter-autoroll
22bcb9d5e [framework] re-enable skipped impeller goldens. (flutter/fl…
8217cb8 
…utter#166354)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 9, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 9, 2025
@engine-flutter-autoroll
22bcb9d5e [framework] re-enable skipped impeller goldens. (flutter/fl…
5aa6e97 
…utter#166354)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 9, 2025
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 11, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 11, 2025
@engine-flutter-autoroll
22bcb9d5e [framework] re-enable skipped impeller goldens. (flutter/fl…
9505620 
…utter#166354)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 11, 2025
@engine-flutter-autoroll
22bcb9d5e [framework] re-enable skipped impeller goldens. (flutter/fl…
253526e 
…utter#166354)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 11, 2025
@engine-flutter-autoroll
22bcb9d5e [framework] re-enable skipped impeller goldens. (flutter/fl…
04e7b5f 
…utter#166354)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 11, 2025
@engine-flutter-autoroll
22bcb9d5e [framework] re-enable skipped impeller goldens. (flutter/fl…
ae133a6 
…utter#166354)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 11, 2025
@engine-flutter-autoroll
22bcb9d5e [framework] re-enable skipped impeller goldens. (flutter/fl…
8797a86 
…utter#166354)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 11, 2025
@engine-flutter-autoroll
22bcb9d5e [framework] re-enable skipped impeller goldens. (flutter/fl…
e51f39d 
…utter#166354)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 11, 2025
@engine-flutter-autoroll
22bcb9d5e [framework] re-enable skipped impeller goldens. (flutter/fl…
4627fa2 
…utter#166354)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 12, 2025
@engine-flutter-autoroll
22bcb9d5e [framework] re-enable skipped impeller goldens. (flutter/fl…
d09fdcd 
…utter#166354)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 12, 2025
@engine-flutter-autoroll
22bcb9d5e [framework] re-enable skipped impeller goldens. (flutter/fl…
f903142 
…utter#166354)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 13, 2025
@engine-flutter-autoroll
22bcb9d5e [framework] re-enable skipped impeller goldens. (flutter/fl…
e3fe624 
…utter#166354)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 14, 2025
@engine-flutter-autoroll
22bcb9d5e [framework] re-enable skipped impeller goldens. (flutter/fl…
2cabaa4 
…utter#166354)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 14, 2025
@engine-flutter-autoroll
22bcb9d5e [framework] re-enable skipped impeller goldens. (flutter/fl…
9c433a0 
…utter#166354)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 14, 2025
@engine-flutter-autoroll
22bcb9d5e [framework] re-enable skipped impeller goldens. (flutter/fl…
572463c 
…utter#166354)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 14, 2025
@engine-flutter-autoroll
22bcb9d5e [framework] re-enable skipped impeller goldens. (flutter/fl…
39e6783 
…utter#166354)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 14, 2025
@engine-flutter-autoroll
22bcb9d5e [framework] re-enable skipped impeller goldens. (flutter/fl…
a0d8c24 
…utter#166354)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 14, 2025
@engine-flutter-autoroll
22bcb9d5e [framework] re-enable skipped impeller goldens. (flutter/fl…
ffc101f 
…utter#166354)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 14, 2025
@engine-flutter-autoroll
22bcb9d5e [framework] re-enable skipped impeller goldens. (flutter/fl…
e009913 
…utter#166354)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 14, 2025
@engine-flutter-autoroll
22bcb9d5e [framework] re-enable skipped impeller goldens. (flutter/fl…
572ef2e 
…utter#166354)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 15, 2025
@engine-flutter-autoroll
22bcb9d5e [framework] re-enable skipped impeller goldens. (flutter/fl…
ada81b1 
…utter#166354)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 15, 2025
@engine-flutter-autoroll
22bcb9d5e [framework] re-enable skipped impeller goldens. (flutter/fl…
fd4c3ec 
…utter#166354)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 15, 2025
@engine-flutter-autoroll
22bcb9d5e [framework] re-enable skipped impeller goldens. (flutter/fl…
46b1510 
…utter#166354)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 15, 2025
@engine-flutter-autoroll
22bcb9d5e [framework] re-enable skipped impeller goldens. (flutter/fl…
6c6ab09 
…utter#166354)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 15, 2025
@engine-flutter-autoroll
22bcb9d5e [framework] re-enable skipped impeller goldens. (flutter/fl…
b2d0b67 
…utter#166354)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
22bcb9d5e [framework] re-enable skipped impeller goldens. (flutter/fl…
9934069 
…utter#166354)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
@engine-flutter-autoroll
22bcb9d5e [framework] re-enable skipped impeller goldens. (flutter/fl…
544b59b 
…utter#166354)
romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull request Aug 14, 2025
@romanejaquez
[framework] re-enable skipped impeller goldens. (flutter#166354)
914ed25 
Fixes flutter#143616

Maybe. Lets see if its stable.

Update: I've run this a few times and it seems stable.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
22bcb9d5e [framework] re-enable skipped impeller goldens. (flutter/fl…
d46b77d 
…utter#166354)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
@engine-flutter-autoroll
22bcb9d5e [framework] re-enable skipped impeller goldens. (flutter/fl…
7fe90bc 
…utter#166354)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
@engine-flutter-autoroll
22bcb9d5e [framework] re-enable skipped impeller goldens. (flutter/fl…
45ab421 
…utter#166354)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matanlurey matanlurey matanlurey approved these changes

Assignees
No one assigned
Labels
a: text input Entering text in a text field or keyboard related problems f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels. will affect goldens Changes to golden files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Impeller] Unskip disabled tests for flutter Test --enable impeller.
2 participants
@jonahwilliams @matanlurey