Fixed issue with data in view class #650
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR addresses the issue raised in #28 by allowing the use of "data" as a key for passing template variables. Key changes include:
- Updating tests/server/template.phtml to check for and render the "data" variable.
- Adding a new route in tests/server/index.php to handle a "data" based template.
- Renaming the render() method parameter and updating docblocks in flight/template/View.php to improve clarity.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/server/template.phtml | Added conditional branch for "$data" handling |
| tests/server/index.php | Introduces a new route to render the template with "data" |
| tests/server/LayoutMiddleware.php | Updated navigation to include the new template route |
| flight/template/View.php | Renamed parameter/documentation from "$data" to "$templateData" |
Comments suppressed due to low confidence (1)
flight/template/View.php:110
- [nitpick] Consider aligning the variable names used in the render() method with the keys provided by controllers (e.g., using 'templateData' versus 'data') to reduce potential confusion.
public function render(string $file, ?array $templateData = null): void
fadrian06
approved these changes
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to flightphp/docs#28 with using "data" as a key in the array.