Skip to content

Add parse method to ParserProxy #576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Add parse method to ParserProxy #576

wants to merge 3 commits into from

Conversation

MaxDall
Copy link
Collaborator

@MaxDall MaxDall commented Aug 5, 2024 •
edited
Loading

The purpose of this PR is to unify the versioning mechanics of ParserProxy and the BaseParser in a new interface called parse within ParserProxy.

#prev
extraction = parser(crawl_date).parse(html, ...)

#now
extraction = parser.parse(html, crawl_date, ...)

This change is primarily a preparation for an upcoming feature that will enable contributors to deprecate individual attributes.

Update: Maybe that's not really necessary

@MaxDall MaxDall requested a review from addie9800 August 5, 2024 15:04
@MaxDall MaxDall marked this pull request as draft August 5, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addie9800 addie9800 Awaiting requested review from addie9800

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MaxDall