Skip to content

coerce dtype=np.int64 for np.prod calls in subsample #806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 20, 2025
Merged

coerce dtype=np.int64 for np.prod calls in subsample #806

merged 4 commits into from
May 20, 2025

Conversation

FlynnOConnell
Copy link
Collaborator

@FlynnOConnell FlynnOConnell commented Apr 25, 2025 •
edited
Loading

Some of my datasets are overflowing during histogram calculation.

raw_scan.shape
Out[1]: (5632, 14, 448, 448)
np.prod(raw_scan.shape)
Out[2]: -1354760192
np.prod(raw_scan.shape, dtype=np.int64)
Out[3]: 15825108992

Also, ignore_dims won't work due to tuple item assignment. Changed that to a list

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 25, 2025 •
edited
Loading

📚 Docs preview built and uploaded! https://www.fastplotlib.org/ver/fix-int-overflow

kushalkolar
kushalkolar requested changes Apr 28, 2025
View reviewed changes
@kushalkolar kushalkolar merged commit 0e1a308 into main May 20, 2025
51 of 52 checks passed
@kushalkolar kushalkolar deleted the fix-int-overflow branch May 21, 2025 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kushalkolar kushalkolar kushalkolar approved these changes

@clewis7 clewis7 Awaiting requested review from clewis7 clewis7 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FlynnOConnell @kushalkolar