♻️ Use mysql's default string length for mariadb #882
Conversation
|
I realize now that it might be worth mentioning that the reason I wanted the default value was because setting the |
|
Damn, so I just ran into this issue when I've executed This is really sad since - if I get it right - this will stop me from using sqlmodel in my current project and switch back to sqlalchemy :(. Thanks for your PR. |
|
Any estimation when this will be merged? |
There was a problem hiding this comment.
LGTM in general!
@itsbekas, thanks for working on this!
Could you please take a look at my comments?
| fake = FakeMetadata() | ||
| fake.max_length = getattr(meta, "max_length", None) | ||
| return fake |
There was a problem hiding this comment.
Seems that this is not needed anymore.
In current version max_length is already used as VARCHAR length (with both Pydantic V1 and V2)
| if impl.length is None and ( | ||
| dialect.name == "mysql" or dialect.name == "mariadb" | ||
| ): |
There was a problem hiding this comment.
| if impl.length is None and ( | |
| dialect.name == "mysql" or dialect.name == "mariadb" | |
| ): | |
| if impl.length is None and dialect.name in ("mysql", "mariadb"): |
A bit more compact and easier to read
As I presented in #881 , mariadb doesn't have a default string size, unlike mysql, which leads to an sqlalchemy compile error. From what I understood (and tried), simply using the mysql default length and checking for the mariadb dialect.name is enough to prevent this error.