Implement Binary Search from py2exe. #74
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
py2exe uses v0.0.3 modified to add binary search to load dll's (like pythonxx.dll) with a ton of exports.
fancycode
added a commit
that referenced
this pull request
Nov 2, 2017
Code based on #74 which contained code from py2exe.
|
Implemented in #76, thanks for the heads up. |
|
Thanks. And sorry for any code I made that did not work initially, I just cant hardly read C code that well as well it becomes all over the place sometimes. I should really consider learning how to read C so that way ceval.c in cpython is no so cancerous for me to even try to understand what it does. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
py2exe uses v0.0.3 modified to add binary search to load dll's (like pythonxx.dll) with a ton of exports.
Let me know if I need to update something to fix problems with this, I tried with a mere copy paste from the version of this that py2exe ships with. I would like this included so that way py2exe dont have to ship an old (patched) special version of the code that could easily have bugs that the current version on this git on branch master patches.So instead I made this Pull request to achieve such. Not to mention what if an in general user (non python or py2exe user needs this binary search that the original py2exe creator patched into this. Either way, I see this more of a useful thing to have in the mainline MemoryModule.