Skip to content

fix(ledc): Allow setting AnalogWrite frequency and resolution before calling analogWrite #11756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(ledc): Allow setting AnalogWrite frequency and resolution before calling analogWrite #11756

wants to merge 1 commit into from
+12 −6

Conversation

P-R-O-C-H-Y
Copy link
Member

Description of Change

This pull request improves the behavior of analogWriteFrequency and analogWriteResolution functions in the esp32-hal-ledc.c file. The changes ensure that when a pin is not yet attached to the LEDC bus, frequency and resolution updates are applied to the global settings that are later used when calling analogWrite.

Improvements to pin-specific configuration:

  • Updated analogWriteFrequency to check if the pin is attached to the LEDC bus and apply the frequency change to the pin, falling back to updating the global frequency if not attached.
  • Updated analogWriteResolution to check if the pin is attached to the LEDC bus and apply the resolution change to the pin, falling back to updating the global resolution if not attached.

Test Scenarios

Tested using simple sketch on ESP32.

void setup() {
  analogWriteFrequency(5,1000);
  analogWriteResolution(5, 10);
  analogWrite(5,1000);
}

void loop() {
  // put your main code here, to run repeatedly:
}

Before:

[   733][E][esp32-hal-ledc.c:788] analogWriteFrequency(): analogWrite frequency cant be set due to selected resolution! Try to adjust resolution first
[   746][E][esp32-hal-ledc.c:796] analogWriteResolution(): analogWrite resolution cant be set due to selected frequency! Try to adjust frequency first
[   762][V][esp32-hal-periman.c:235] perimanSetBusDeinit(): Deinit function for type LEDC (12) successfully set to 0x400d17b0
[   775][D][esp32-hal-ledc.c:53] find_matching_timer(): Searching for timer with freq=1000, resolution=8
[   786][D][esp32-hal-ledc.c:69] find_matching_timer(): No matching timer found for freq=1000, resolution=8
[   798][D][esp32-hal-ledc.c:97] find_free_timer(): Found free timer 0
[   807][V][esp32-hal-periman.c:160] perimanSetPinBus(): Pin 5 successfully set to type LEDC (12) with bus 0x3ffb8524
[   819][I][esp32-hal-ledc.c:288] ledcAttachChannel(): LEDC attached to pin 5 (channel 0, resolution 8)

After:

[   733][V][esp32-hal-periman.c:235] perimanSetBusDeinit(): Deinit function for type LEDC (12) successfully set to 0x400d17bc
[   744][D][esp32-hal-ledc.c:53] find_matching_timer(): Searching for timer with freq=1000, resolution=10
[   756][D][esp32-hal-ledc.c:69] find_matching_timer(): No matching timer found for freq=1000, resolution=10
[   767][D][esp32-hal-ledc.c:97] find_free_timer(): Found free timer 0
[   776][V][esp32-hal-periman.c:160] perimanSetPinBus(): Pin 5 successfully set to type LEDC (12) with bus 0x3ffb8524
[   788][I][esp32-hal-ledc.c:288] ledcAttachChannel(): LEDC attached to pin 5 (channel 0, resolution 10)

Related links

Closes #11670

@P-R-O-C-H-Y P-R-O-C-H-Y self-assigned this Aug 22, 2025
@P-R-O-C-H-Y P-R-O-C-H-Y requested a review from a team as a code owner August 22, 2025 12:33
@P-R-O-C-H-Y P-R-O-C-H-Y added Type: Bug 🐛 All bugs Area: Peripherals API Relates to peripheral's APIs. Status: Review needed Issue or PR is awaiting review labels Aug 22, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 22, 2025 •
edited
Loading

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello P-R-O-C-H-Y, we appreciate your contribution to this project!

📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.
🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.
Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against bd405d2

@P-R-O-C-H-Y P-R-O-C-H-Y force-pushed the fix/analog-freq-resolution branch from 82b13e5 to bd405d2 Compare August 22, 2025 12:33
@github-actions GitHub Actions
Copy link
Contributor

Test Results

 76 files   76 suites   13m 10s ⏱️
 38 tests  38 ✅ 0 💤 0 ❌
241 runs  241 ✅ 0 💤 0 ❌

Results for commit bd405d2.

@github-actions GitHub Actions
Copy link
Contributor

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32C5000.000.00000.000.00
ESP32P4000.000.00000.000.00
ESP32S3000.000.00000.000.00
ESP32S2000.000.00000.000.00
ESP32C3000.000.00000.000.00
ESP32C6000.000.00000.000.00
ESP32H2000.000.00000.000.00
ESP320⚠️ +160.000.00000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32C5ESP32P4ESP32S3ESP32S2ESP32C3ESP32C6ESP32H2ESP32
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
ArduinoOTA/examples/BasicOTA000000000000--00
AsyncUDP/examples/AsyncUDPClient000000000000--00
AsyncUDP/examples/AsyncUDPMulticastServer000000000000--00
AsyncUDP/examples/AsyncUDPServer000000000000--00
BLE/examples/Beacon_Scanner00--00--00000000
BLE/examples/Client00--00--00000000
BLE/examples/EddystoneTLM_Beacon00--00--00000000
BLE/examples/EddystoneURL_Beacon00--00--00000000
BLE/examples/Notify00--00--00000000
BLE/examples/Scan00--00--00000000
BLE/examples/Server00--00--00000000
BLE/examples/Server_multiconnect00--00--00000000
BLE/examples/UART00--00--00000000
BLE/examples/Write00--00--00000000
BLE/examples/iBeacon00--00--00000000
DNSServer/examples/CaptivePortal000000000000--00
EEPROM/examples/eeprom_class0000000000000000
EEPROM/examples/eeprom_extra0000000000000000
EEPROM/examples/eeprom_write0000000000000000
ESP32/examples/AnalogOut/LEDCFade0000000000000000
ESP32/examples/AnalogOut/LEDCGammaFade0000------0000--
ESP32/examples/AnalogOut/LEDCSingleChannel0000000000000000
ESP32/examples/AnalogOut/LEDCSoftwareFade0000000000000000
ESP32/examples/AnalogOut/SigmaDelta0000000000000000
ESP32/examples/AnalogOut/ledcFrequency0000000000000000
ESP32/examples/AnalogOut/ledcWrite_RGB0000000000000000
ESP32/examples/AnalogRead0000000000000000
ESP32/examples/AnalogReadContinuous0000000000000000
ESP32/examples/ArduinoStackSize0000000000000000
ESP32/examples/CI/CIBoardsTest0000000000000000
ESP32/examples/ChipID/GetChipID0000000000000000
ESP32/examples/DeepSleep/TimerWakeUp000000000000--00
ESP32/examples/FreeRTOS/BasicMultiThreading0000000000000000
ESP32/examples/FreeRTOS/Mutex0000000000000000
ESP32/examples/FreeRTOS/Queue0000000000000000
ESP32/examples/FreeRTOS/Semaphore0000000000000000
ESP32/examples/GPIO/BlinkRGB0000000000000000
ESP32/examples/GPIO/FunctionalInterrupt0000000000000000
ESP32/examples/GPIO/FunctionalInterruptLambda0000000000000000
ESP32/examples/GPIO/FunctionalInterruptStruct0000000000000000
ESP32/examples/GPIO/GPIOInterrupt0000000000000000
ESP32/examples/HWCDC_Events000000--000000--
ESP32/examples/MacAddress/GetMacAddress0000000000000000
ESP32/examples/RMT/Legacy_RMT_Driver_Compatible0000000000000000
ESP32/examples/RMT/RMTCallback0000000000000000
ESP32/examples/RMT/RMTLoopback0000000000000000
ESP32/examples/RMT/RMTReadXJT0000000000000000
ESP32/examples/RMT/RMTWrite_RGB_LED0000000000000000
ESP32/examples/RMT/RMT_CPUFreq_Test0000000000000000
ESP32/examples/RMT/RMT_EndOfTransmissionState0000000000000000
ESP32/examples/RMT/RMT_LED_Blink0000000000000000
ESP32/examples/ResetReason/ResetReason0000000000000000
ESP32/examples/ResetReason/ResetReason20000000000000000
ESP32/examples/Serial/BaudRateDetect_Demo0000000000000000
ESP32/examples/Serial/OnReceiveError_BREAK_Demo0000000000000000
ESP32/examples/Serial/OnReceive_Demo0000000000000000
ESP32/examples/Serial/RS485_Echo_Demo0000000000000000
ESP32/examples/Serial/RxFIFOFull_Demo0000000000000000
ESP32/examples/Serial/RxTimeout_Demo0000000000000000
ESP32/examples/Serial/Serial_All_CPU_Freqs0000000000000000
ESP32/examples/Serial/Serial_STD_Func_OnReceive0000000000000000
ESP32/examples/Serial/onReceiveExample0000000000000000
ESP32/examples/Template/ExampleTemplate0000000000000000
ESP32/examples/Time/SimpleTime000000000000--00
ESP32/examples/Timer/RepeatTimer0000000000000000
ESP32/examples/Timer/WatchdogTimer0000000000000000
ESP32/examples/Utilities/HEXBuilder0000000000000000
ESP32/examples/Utilities/MD5Builder0000000000000000
ESP32/examples/Utilities/SHA1Builder0000000000000000
ESP_I2S/examples/ES8388_loopback0000000000000000
ESP_I2S/examples/Simple_tone0000000000000000
ESP_NOW/examples/ESP_NOW_Broadcast_Master00--00000000--00
ESP_NOW/examples/ESP_NOW_Broadcast_Slave00--00000000--00
ESP_NOW/examples/ESP_NOW_Network00--00000000--00
ESP_NOW/examples/ESP_NOW_Serial00--00000000--00
ESPmDNS/examples/mDNS-SD_Extended000000000000--00
ESPmDNS/examples/mDNS_Web_Server000000000000--00
Ethernet/examples/ETH_W5500_Arduino_SPI0000000000000000
Ethernet/examples/ETH_W5500_IDF_SPI0000000000000000
Ethernet/examples/ETH_WIFI_BRIDGE000000000000--00
FFat/examples/FFat_Test0000000000000000
FFat/examples/FFat_time000000000000--00
HTTPClient/examples/Authorization000000000000--00
HTTPClient/examples/BasicHttpClient000000000000--00
HTTPClient/examples/BasicHttpsClient000000000000--00
HTTPClient/examples/HTTPClientEnterprise00--00000000--00
HTTPClient/examples/ReuseConnection000000000000--00
HTTPClient/examples/StreamHttpClient000000000000--00
HTTPUpdate/examples/httpUpdate000000000000--00
HTTPUpdate/examples/httpUpdateSPIFFS000000000000--00
HTTPUpdate/examples/httpUpdateSecure000000000000--00
HTTPUpdateServer/examples/WebUpdater000000000000--00
Insights/examples/DiagnosticsSmokeTest00--00000000--00
Insights/examples/MinimalDiagnostics00--00000000--00
LittleFS/examples/LITTLEFS_test0000000000000000
LittleFS/examples/LITTLEFS_time000000000000--00
Matter/examples/MatterColorLight00--000000000000
Matter/examples/MatterCommissionTest00--000000000000
Matter/examples/MatterComposedLights00--000000000000
Matter/examples/MatterContactSensor00--000000000000
Matter/examples/MatterDimmableLight00--000000000000
Matter/examples/MatterEnhancedColorLight00--000000000000
Matter/examples/MatterEvents00--000000000000
Matter/examples/MatterFan00--000000000000
Matter/examples/MatterHumiditySensor00--000000000000
Matter/examples/MatterLambdaSingleCallbackManyEPs00--000000000000
Matter/examples/MatterMinimum00--000000000000
Matter/examples/MatterOccupancySensor00--000000000000
Matter/examples/MatterOnIdentify00--000000000000
Matter/examples/MatterOnOffLight00--000000000000
Matter/examples/MatterOnOffPlugin00--000000000000
Matter/examples/MatterPressureSensor00--000000000000
Matter/examples/MatterSmartButon00--000000000000
Matter/examples/MatterTemperatureLight00--000000000000
Matter/examples/MatterTemperatureSensor00--000000000000
Matter/examples/MatterThermostat00--000000000000
NetBIOS/examples/ESP_NBNST000000000000--00
NetworkClientSecure/examples/WiFiClientInsecure000000000000--00
NetworkClientSecure/examples/WiFiClientPSK000000000000--00
NetworkClientSecure/examples/WiFiClientSecure000000000000--00
NetworkClientSecure/examples/WiFiClientSecureEnterprise00--00000000--00
NetworkClientSecure/examples/WiFiClientSecureProtocolUpgrade000000000000--00
NetworkClientSecure/examples/WiFiClientShowPeerCredentials000000000000--00
NetworkClientSecure/examples/WiFiClientTrustOnFirstUse000000000000--00
OpenThread/examples/CLI/COAP/coap_lamp00--------0000--
OpenThread/examples/CLI/COAP/coap_switch00--------0000--
OpenThread/examples/CLI/SimpleCLI00--------0000--
OpenThread/examples/CLI/SimpleNode00--------0000--
OpenThread/examples/CLI/SimpleThreadNetwork/ExtendedRouterNode00--------0000--
OpenThread/examples/CLI/SimpleThreadNetwork/LeaderNode00--------0000--
OpenThread/examples/CLI/SimpleThreadNetwork/RouterNode00--------0000--
OpenThread/examples/CLI/ThreadScan00--------0000--
OpenThread/examples/CLI/onReceive00--------0000--
OpenThread/examples/Native/SimpleThreadNetwork/LeaderNode00--------0000--
OpenThread/examples/Native/SimpleThreadNetwork/RouterNode00--------0000--
PPP/examples/PPP_Basic0000000000000000
PPP/examples/PPP_WIFI_BRIDGE000000000000--00
Preferences/examples/Prefs2Struct0000000000000000
Preferences/examples/StartCounter0000000000000000
RainMaker/examples/RMakerCustom00--00000000----
RainMaker/examples/RMakerCustomAirCooler00--00000000----
RainMaker/examples/RMakerSonoffDualR300--00000000----
RainMaker/examples/RMakerSwitch00--00000000----
SD/examples/SD_Test0000000000000000
SD/examples/SD_time000000000000--00
SPI/examples/SPI_Multiple_Buses0000000000000000
SPIFFS/examples/SPIFFS_Test0000000000000000
SPIFFS/examples/SPIFFS_time000000000000--00
TFLiteMicro/examples/hello_world0000000000000000
Ticker/examples/Blinker0000000000000000
Ticker/examples/TickerBasic0000000000000000
Ticker/examples/TickerParameter0000000000000000
Update/examples/AWS_S3_OTA_Update000000000000--00
Update/examples/HTTPS_OTA_Update000000000000--00
Update/examples/HTTP_Client_AES_OTA_Update000000000000--00
Update/examples/HTTP_Server_AES_OTA_Update000000000000--⚠️ +160
Update/examples/OTAWebUpdater000000000000--00
Update/examples/SD_Update0000000000000000
WebServer/examples/AdvancedWebServer000000000000--00
WebServer/examples/FSBrowser000000000000--00
WebServer/examples/Filters000000000000--00
WebServer/examples/HelloServer000000000000--00
WebServer/examples/HttpAdvancedAuth000000000000--00
WebServer/examples/HttpAuthCallback000000000000--00
WebServer/examples/HttpAuthCallbackInline000000000000--00
WebServer/examples/HttpBasicAuth000000000000--00
WebServer/examples/HttpBasicAuthSHA1000000000000--00
WebServer/examples/HttpBasicAuthSHA1orBearerToken000000000000--00
WebServer/examples/Middleware00--00000000--00
WebServer/examples/MultiHomedServers000000000000--00
WebServer/examples/PathArgServer000000000000--00
WebServer/examples/SDWebServer000000000000--00
WebServer/examples/SimpleAuthentification000000000000--00
WebServer/examples/UploadHugeFile000000000000--00
WebServer/examples/WebServer000000000000--00
WebServer/examples/WebUpdate000000000000--00
WiFi/examples/FTM/FTM_Initiator000000000000--00
WiFi/examples/FTM/FTM_Responder000000000000--00
WiFi/examples/SimpleWiFiServer000000000000--00
WiFi/examples/WPS00--00000000--00
WiFi/examples/WiFiAccessPoint000000000000--00
WiFi/examples/WiFiBlueToothSwitch00--00--0000--00
WiFi/examples/WiFiClient000000000000--00
WiFi/examples/WiFiClientBasic000000000000--00
WiFi/examples/WiFiClientConnect000000000000--00
WiFi/examples/WiFiClientEnterprise00--00000000--00
WiFi/examples/WiFiClientEvents000000000000--00
WiFi/examples/WiFiClientStaticIP000000000000--00
WiFi/examples/WiFiExtender000000000000--00
WiFi/examples/WiFiIPv6000000000000--00
WiFi/examples/WiFiMulti000000000000--00
WiFi/examples/WiFiMultiAdvanced000000000000--00
WiFi/examples/WiFiScan000000000000--00
WiFi/examples/WiFiScanAsync000000000000--00
WiFi/examples/WiFiScanDualAntenna000000000000--00
WiFi/examples/WiFiScanTime000000000000--00
WiFi/examples/WiFiSmartConfig00--00000000--00
WiFi/examples/WiFiTelnetToSerial000000000000--00
WiFi/examples/WiFiUDPClient000000000000--00
WiFiProv/examples/WiFiProv00--00000000--00
Wire/examples/WireMaster0000000000000000
Wire/examples/WireScan0000000000000000
Wire/examples/WireSlave0000000000000000
Wire/examples/WireSlaveFunctionalCallback0000000000000000
Zigbee/examples/Zigbee_Analog_Input_Output00--000000000000
Zigbee/examples/Zigbee_Binary_Input00--------0000--
Zigbee/examples/Zigbee_CarbonDioxide_Sensor00--------0000--
Zigbee/examples/Zigbee_Color_Dimmable_Light00--------0000--
Zigbee/examples/Zigbee_Color_Dimmer_Switch00--000000000000
Zigbee/examples/Zigbee_Contact_Switch00--------0000--
Zigbee/examples/Zigbee_Dimmable_Light00--------0000--
Zigbee/examples/Zigbee_Electrical_AC_Sensor00--000000000000
Zigbee/examples/Zigbee_Electrical_AC_Sensor_MultiPhase00--000000000000
Zigbee/examples/Zigbee_Electrical_DC_Sensor00--------0000--
Zigbee/examples/Zigbee_Fan_Control00--000000000000
Zigbee/examples/Zigbee_Gateway00--000000----00
Zigbee/examples/Zigbee_Illuminance_Sensor00--------0000--
Zigbee/examples/Zigbee_OTA_Client00--------0000--
Zigbee/examples/Zigbee_Occupancy_Sensor00--------0000--
Zigbee/examples/Zigbee_On_Off_Light00--------0000--
Zigbee/examples/Zigbee_On_Off_MultiSwitch00--000000000000
Zigbee/examples/Zigbee_On_Off_Switch00--000000000000
Zigbee/examples/Zigbee_PM25_Sensor00--------0000--
Zigbee/examples/Zigbee_Power_Outlet00--000000000000
Zigbee/examples/Zigbee_Pressure_Flow_Sensor00--------0000--
Zigbee/examples/Zigbee_Range_Extender00--000000000000
Zigbee/examples/Zigbee_Scan_Networks00--------0000--
Zigbee/examples/Zigbee_Temp_Hum_Sensor_Sleepy00--------0000--
Zigbee/examples/Zigbee_Temperature_Sensor00--------0000--
Zigbee/examples/Zigbee_Thermostat00--000000000000
Zigbee/examples/Zigbee_Vibration_Sensor00--------0000--
Zigbee/examples/Zigbee_Wind_Speed_Sensor00--------0000--
Zigbee/examples/Zigbee_Window_Covering00--------0000--
ESP32/examples/DeepSleep/TouchWakeUp--000000------00
ESP32/examples/TWAI/TWAIreceive--00000000000000
ESP32/examples/TWAI/TWAItransmit--00000000000000
ESP32/examples/Touch/TouchInterrupt--000000------00
ESP32/examples/Touch/TouchRead--000000------00
ESP_I2S/examples/Record_to_WAV--0000--------00
Ethernet/examples/ETH_TLK110--00----------00
SD_MMC/examples/SD2USBMSC--0000----------
SD_MMC/examples/SDMMC_Test--0000--------00
SD_MMC/examples/SDMMC_time--0000--------00
USB/examples/CompositeDevice--000000--------
USB/examples/ConsumerControl--000000--------
USB/examples/CustomHIDDevice--000000--------
USB/examples/FirmwareMSC--000000--------
USB/examples/Gamepad--000000--------
USB/examples/HIDVendor--000000--------
USB/examples/Keyboard/KeyboardLogout--000000--------
USB/examples/Keyboard/KeyboardMessage--000000--------
USB/examples/Keyboard/KeyboardReprogram--000000--------
USB/examples/Keyboard/KeyboardSerial--000000--------
USB/examples/KeyboardAndMouseControl--000000--------
USB/examples/MIDI/MidiController--000000--------
USB/examples/MIDI/MidiInterface--000000--------
USB/examples/MIDI/MidiMusicBox--000000--------
USB/examples/MIDI/ReceiveMidi--000000--------
USB/examples/Mouse/ButtonMouseControl--000000--------
USB/examples/SystemControl--000000--------
USB/examples/USBMSC--000000--------
USB/examples/USBSerial--000000--------
USB/examples/USBVendor--000000--------
ESP32/examples/Camera/CameraWebServer (1)----0000------00
ESP32/examples/Camera/CameraWebServer (2)----0000------00
ESP32/examples/Camera/CameraWebServer (3)----00----------
ESP32/examples/DeepSleep/ExternalWakeUp----0000------00
ESP_SR/examples/Basic----00----------
BluetoothSerial/examples/DiscoverConnect--------------00
BluetoothSerial/examples/GetLocalMAC--------------00
BluetoothSerial/examples/SerialToSerialBT--------------00
BluetoothSerial/examples/SerialToSerialBTM--------------00
BluetoothSerial/examples/SerialToSerialBT_Legacy--------------00
BluetoothSerial/examples/SerialToSerialBT_SSP--------------00
BluetoothSerial/examples/bt_classic_device_discovery--------------00
BluetoothSerial/examples/bt_remove_paired_devices--------------00
ESP32/examples/DeepSleep/SmoothBlink_ULP_Code--------------00
Ethernet/examples/ETH_LAN8720--------------00
SimpleBLE/examples/SimpleBleDevice--------------00

@SuGlider SuGlider requested a review from Copilot August 22, 2025 16:40
Copilot
Copilot AI reviewed Aug 22, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the behavior of analogWriteFrequency and analogWriteResolution functions to allow setting frequency and resolution parameters before calling analogWrite. Previously, these functions would fail if called before the pin was attached to the LEDC bus.

  • Added pin attachment checks to both functions before attempting to change pin-specific settings
  • Functions now fall back to updating global settings when pin is not yet attached
  • Eliminates error messages when configuring frequency/resolution before analogWrite

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@SuGlider SuGlider self-requested a review August 22, 2025 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@lucasssvaz lucasssvaz lucasssvaz approved these changes

@SuGlider SuGlider SuGlider approved these changes

@me-no-dev me-no-dev Awaiting requested review from me-no-dev

Assignees

@P-R-O-C-H-Y P-R-O-C-H-Y

Labels
Area: Peripherals API Relates to peripheral's APIs. Status: Review needed Issue or PR is awaiting review Type: Bug 🐛 All bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

analogWriteResolution not working
3 participants
@P-R-O-C-H-Y @lucasssvaz @SuGlider