Skip to content

Fix redirect support in http client. #7039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 28, 2020
Merged

Fix redirect support in http client. #7039

merged 3 commits into from
Jan 28, 2020

Conversation

liebman
Copy link
Contributor

@liebman liebman commented Jan 28, 2020 •
edited
Loading

Looks like this was introduced in #5250 - it missed the need to clear _canReuse in setUrl() if the new URL has a hostname and is not just a path. Without it disconnect() will assume it can reuse even tho the hostname may be different.

fixes #7033

@devyte devyte merged commit 9e9515b into esp8266:master Jan 28, 2020
@devyte devyte added this to the 2.7.0 milestone Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@earlephilhower earlephilhower earlephilhower approved these changes

Assignees
No one assigned
Labels
component: libraries type: bug
Projects
None yet
Milestone
2.7.0
Development

Successfully merging this pull request may close these issues.

File download from https server does not work
3 participants
@liebman @earlephilhower @devyte