Skip to content

Use 401 with Authenticate header, when appropriate #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

robromano
Copy link
Contributor

This is attempt to fix Issue #187 - 401 v.s. 403 - with your recommendations from the unauthenticated_response branch.

@lovelydinosaur
Copy link
Member

Apologies, I was also working on this in the unauthenticated_response branch, but hadn't yet pushed.
See #416. Maybe you could look into updating this against the branch?
I think we'll have a few things to iron out along the way to getting this in.

@robromano
Copy link
Contributor Author

I made my changes on the 'unauthenticated_response' branch, do you mean I should update against master? I'm a little new to the differences between forks, and branches, so forgive me if I am misunderstanding. Here is what git branch -a shows on my local repo:

rromano-air:django-rest-framework rromano$ git branch -a
  master
* unauthenticated_response
  remotes/origin/0.4.X
  remotes/origin/HEAD -> origin/master
  remotes/origin/gh-pages
  remotes/origin/master
  remotes/origin/read_only_fields
  remotes/origin/resources-routers
  remotes/origin/unauthenticated_response
  remotes/upstream/0.4.X
  remotes/upstream/gh-pages
  remotes/upstream/master
  remotes/upstream/read_only_fields
  remotes/upstream/resources-routers
  remotes/upstream/unauthenticated_response 

@robromano
Copy link
Contributor Author

I see your changes now, and merged. Looks like we were doing the same thing at around the same time. I think you already have the equivalent, so nothing really to merge. Closing this pull req, let me know if I can help out. What's next for 403 vs 401?

@robromano robromano closed this Nov 20, 2012
treyhunner pushed a commit to treyhunner/django-rest-framework that referenced this pull request Sep 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants