[test] Remove slack when checking for expected file size #24512
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These days we force the sizes to be up-to-date on each commit (during CI) so we don't tolerate any slack of differences here. We recently has an issue with line endings that was masked by this slack and took quite while to debug: emscripten-core#24488.
RReverser
approved these changes
Jun 6, 2025
Lukasdoe
pushed a commit
to Lukasdoe/emscripten
that referenced
this pull request
Jun 19, 2025
…core#24512) These days we force the sizes to be up-to-date on each commit (during CI) so we don't tolerate any slack of differences here. We recently has an issue with line endings that was masked by this slack and took quite while to debug: emscripten-core#24488.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These days we force the sizes to be up-to-date on each commit (during CI) so we don't tolerate any slack of differences here.
We recently has an issue with line endings that was masked by this slack and took quite while to debug: #24488.