Skip to content

Fix wrong usage of "eval-when-compile". #1180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 22, 2025

Conversation

thattemperature
Copy link
Contributor

The usage of eval-when-compile is wrong here. If you really do byte-compile (or do native-compile further) and load the compiled file at run time, you will find that the add-hook and add-to-list do not work. In fact they only work at compile time and change the compilation environment, not at run time. use eval-and-compile can fix that problem.

@manateelazycat manateelazycat merged commit dc5f6e7 into emacs-eaf:master Aug 22, 2025
@manateelazycat
Copy link
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants