Add a check to ensure broker connection is ready during poll if auto commit is disabled #2672
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potentially fixes #2667
If
enable_auto_commit=Falsethe CPU usage of a kafka consumer increases to 100% if the broker connection is lost. Ifenable_auto_commit=True, the connection loss is detected by the periodic auto commit, which acts as a sort of health check in this case.I added a similar check to the
pollmethod. I am not sure if this the best location, thats why I also did not add any test yet.We might also only check the readiness in case
enabled_auto_commit=False.Looking forward to your feedback.