rename binlog #440
Merged
rename binlog #440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b70c885 to
303dfae
Compare
|
Isn't eng\build.ps1 still referenced from build.cmd - Line 2 in 4a983a6 |
|
Could you please give more details about this change? Did arcade take the log name argument change? |
|
No they didn't. This change is a different workaround than the previous one. This one will allow us to stay on their common scripts but send our own /bl argument to msbuild to have the binary log named whatever we want it to be |
JuditRose
approved these changes
Feb 14, 2019
|
How did you test these changes?
Where is msbuild invoked ? could you please point me to this code? |
I tested locally (just now) and it is tested as part of the CI. you can check the results of the CI yourself as well if you want 😄
It is in build.ps1 Line 87 in 2e142bb |
build.ps1 accepts both arguments for its own logic as well as overflow arguments for msbuild. If build.ps1 does not know what to do with a given argument (like the /bl:path\to\binlog one), it will pass them straight through to msbuild I knew this but thought that it would not matter since the script is also sending its own bl flag, but it turns out msbuild uses the last one and not the first one, so we're taking advantage of that behavior from msbuild to be able to name the binary logs whatever we want. |
|
Looks good, thank you for the explanations.
I actually don't know how to access artifacts for the PR build. |
Tanya-Solyanik
approved these changes
Feb 14, 2019
If you go to the CI by clicking Show all checks at the bottom of the PR And then clicking Details on the dotnet-winforms CI check That will bring you to the page below (you can also get there by clicking the Checks tab on the top of the PR). On there, select "View more details on Azure Pipelines" You will then be brought to the page below where you can select the "Artifacts" button in the top right to download the artifacts for each build job Note however that if you want to check the package, it will only be produced as a build artifact on signed builds, which are those performed on the internal build system only. For these, go to https://dnceng.visualstudio.com/internal/_build?definitionId=164 and select the build which corresponds to the mirrored merge to master or Release/* that you are interested in. Then you can download the build artifacts by pressing the "Artifacts" button like above. |
|
Thank you for the pictures! |
happy to demystify 👻 |
zsd4yr
added a commit
that referenced
this pull request
Feb 27, 2019
* rename Build.binlog * we don't need out own anymore * switch back for local build as well
JuditRose
added a commit
that referenced
this pull request
Feb 28, 2019
* adding collection editor and object selector editor * Moving ClientUtils and RTLAwareMessageBox to commons * fixing PR comments, moving DpiAwernessContext to common, removing unneccessary (commented out) code and comments * changing namespace and minor fixes requested in PR * added new classes to ref * remove ported components from api compat file * replaced <devdoc> tags with <summary>, fixed a few minor PR comments * changing using statement back * adding auto generated resource files * added unit tests for object selector editor * adding collection editor unit tests * add assertion to testcase * fix namespacing * index on WFI177-add-missing-editors: 81b9089 add assertion to testcase * successfully added to ref assembly * fix include in RTLAwareMessageBox and alphabetize usings in ClientUtils * join all SR in the System namespace * remove comment header from top of SR.resx files for System.Windows.Forms and System.Windows.Forms.Design.Editors; already done for System.Windows.Forms.Design * Fix text in the ThreadExceptionDialog (#430) Fixes #202 * replaced hardcoded text that represents a resource name with a get …property that reads this resource * replaced explicit \r\n strings in SR.RESX file for system.windows.forms.dll with newlines because resx reader escapes them and as a result we don't have new lines in the displayed text * for other assemblies in this repo, I created a tracking issue to fix SR.resx files: #429 * added a test for this dialog to `WinformsControlsTest`, @zsd4yr - please review, I tested this change by running the app, is there anything else to run Before:  After:  * Update dependencies from https://github.com/dotnet/corefx build 20190213.23 (#444) This change updates the following dependencies - System.CodeDom - 4.6.0-preview4.19113.23 - Microsoft.Win32.SystemEvents - 4.6.0-preview4.19113.23 - Microsoft.Win32.Registry - 4.6.0-preview4.19113.23 - System.Windows.Extensions - 4.6.0-preview4.19113.23 - System.Configuration.ConfigurationManager - 4.6.0-preview4.19113.23 - System.Security.Cryptography.Cng - 4.6.0-preview4.19113.23 - System.Security.Permissions - 4.6.0-preview4.19113.23 - System.Drawing.Common - 4.6.0-preview4.19113.23 * Update dependencies from https://github.com/dotnet/arcade build 20190213.1 (#443) This change updates the following dependencies - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19113.1 * rename binlog (#440) * rename Build.binlog * we don't need out own anymore * switch back for local build as well * Exclude documentation files from NuGet package (#441) * enable resource dlls in package (#445) * Update .NET Core SDK link. (#442) * Update .NET Core SDK link. * Remove preview moniker from link text. * Update the link text. * Update dependencies from https://github.com/dotnet/corefx build 20190215.1 (#447) This change updates the following dependencies - System.CodeDom - 4.6.0-preview4.19115.1 - Microsoft.Win32.Registry - 4.6.0-preview4.19115.1 - Microsoft.Win32.SystemEvents - 4.6.0-preview4.19115.1 - System.Security.Cryptography.Cng - 4.6.0-preview4.19115.1 - System.Security.Permissions - 4.6.0-preview4.19115.1 - System.Configuration.ConfigurationManager - 4.6.0-preview4.19115.1 - System.Windows.Extensions - 4.6.0-preview4.19115.1 - System.Drawing.Common - 4.6.0-preview4.19115.1 * Update dependencies from https://github.com/dotnet/arcade build 20190214.4 (#446) This change updates the following dependencies - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19114.4 * Adding basic tests for AccessibleObjects (#435) * Adding basic tests for ComboBoxAccessibleObject, DataGridViewAccessibleObject, PropertyGridAccessibleObject and ToolStripAccessibleObject. * Make tested currentUICulture equal to currentCulture on the Thread (#453) * enable resource dlls in package * ensure ui culture is current culture * Update dependencies from https://github.com/dotnet/arcade build 20190215.1 (#455) This change updates the following dependencies - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19115.1 * [master] Update dependencies from dotnet/corefx (#456) * Update dependencies from https://github.com/dotnet/corefx build 20190217.1 This change updates the following dependencies - System.CodeDom - 4.6.0-preview4.19117.1 - Microsoft.Win32.Registry - 4.6.0-preview4.19117.1 - Microsoft.Win32.SystemEvents - 4.6.0-preview4.19117.1 - System.Security.Cryptography.Cng - 4.6.0-preview4.19117.1 - System.Security.Permissions - 4.6.0-preview4.19117.1 - System.Configuration.ConfigurationManager - 4.6.0-preview4.19117.1 - System.Windows.Extensions - 4.6.0-preview4.19117.1 - System.Drawing.Common - 4.6.0-preview4.19117.1 * Update dependencies from https://github.com/dotnet/corefx build 20190218.1 This change updates the following dependencies - System.CodeDom - 4.6.0-preview4.19118.1 - Microsoft.Win32.Registry - 4.6.0-preview4.19118.1 - Microsoft.Win32.SystemEvents - 4.6.0-preview4.19118.1 - System.Security.Cryptography.Cng - 4.6.0-preview4.19118.1 - System.Security.Permissions - 4.6.0-preview4.19118.1 - System.Configuration.ConfigurationManager - 4.6.0-preview4.19118.1 - System.Windows.Extensions - 4.6.0-preview4.19118.1 - System.Drawing.Common - 4.6.0-preview4.19118.1 * Update dependencies from https://github.com/dotnet/corefx build 20190218.6 This change updates the following dependencies - System.CodeDom - 4.6.0-preview4.19118.6 - Microsoft.Win32.Registry - 4.6.0-preview4.19118.6 - Microsoft.Win32.SystemEvents - 4.6.0-preview4.19118.6 - System.Security.Cryptography.Cng - 4.6.0-preview4.19118.6 - System.Security.Permissions - 4.6.0-preview4.19118.6 - System.Configuration.ConfigurationManager - 4.6.0-preview4.19118.6 - System.Windows.Extensions - 4.6.0-preview4.19118.6 - System.Drawing.Common - 4.6.0-preview4.19118.6 * Fixed Clipboard.SetDataObject to work with custom formats #415 (#416) fixes #415 While testing SpreadsheetGear for Windows Forms on .NET Core 3 we found that Clipboard.SetDataObject writes uninitialized data to the clipboard instead of serialized .NET objects. This bug is apparently a regression from Span<T> work in 37abb3a. * Remove dead code from binding (#393) * Update dependencies from https://github.com/dotnet/arcade build 20190219.2 (#461) This change updates the following dependencies - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19119.2 * LOC CHECKIN | dotnet/winforms master | 20190221 (#467) * Update dependencies from https://github.com/dotnet/arcade build 20190221.1 (#466) This change updates the following dependencies - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19121.1 * Set copyright and package license (#470) * Update dependencies from https://github.com/dotnet/arcade build 20190221.5 (#474) This change updates the following dependencies - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19121.5 * [master] Update dependencies from dotnet/arcade (#481) * Update dependencies from https://github.com/dotnet/arcade build 20190222.3 This change updates the following dependencies - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19122.3 * Update dependencies from https://github.com/dotnet/arcade build 20190223.1 This change updates the following dependencies - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19123.1 * Update dependencies from https://github.com/dotnet/arcade build 20190224.1 This change updates the following dependencies - Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19124.1 * fix downgrade netcore platforms (#479) * fix downgrade netcore platforms * MicrosoftNETCorePlatforms is a CoreFX dependency * change version to match other CoreFX dependencies; add to Version.Details.xml * [master] Update dependencies from dotnet/corefx (#483) * Update dependencies from https://github.com/dotnet/corefx build 20190223.2 This change updates the following dependencies - System.CodeDom - 4.6.0-preview4.19123.2 - Microsoft.Win32.Registry - 4.6.0-preview4.19123.2 - Microsoft.Win32.SystemEvents - 4.6.0-preview4.19123.2 - System.Security.Cryptography.Cng - 4.6.0-preview4.19123.2 - System.Security.Permissions - 4.6.0-preview4.19123.2 - System.Configuration.ConfigurationManager - 4.6.0-preview4.19123.2 - System.Windows.Extensions - 4.6.0-preview4.19123.2 - System.Drawing.Common - 4.6.0-preview4.19123.2 * Update Version.Details.xml * Fix InputLanguage null refs and add tests (#380) * Fix InputLanguage null refs and add tests * Update src/System.Windows.Forms/src/System/Windows/Forms/InputLanguage.cs Co-Authored-By: hughbe <hughbellars@gmail.com> * Save files as utf-8-bom (#487) * Save files as UTF-8 (all files that did not change) * Save files as UTF-8 (files with changes) * Improve validation of Table arguments (#381) * Added CheckParentingCycle, that check for any circular reference in the ancestors chain. (#454) * Closes #358, Added CheckParentingCycle, that check for any circular reference in the ancestors chain. * xlf resource files updated * Refactored method CheckParentingCycle so that it has only one throw statement * Removed reference to .uex file * Removed character related to different encoding * Added UnitTest to TreeView To check the case of adding a circular reference to the ancestors chain * Fix typo (#492) * successfully added to ref assembly * fix include in RTLAwareMessageBox and alphabetize usings in ClientUtils * join all SR in the System namespace * remove comment header from top of SR.resx files for System.Windows.Forms and System.Windows.Forms.Design.Editors; already done for System.Windows.Forms.Design * typo * it is unnecessary to generate source for Resources\CollectionEditor.resx * add comments above public methods * make internal as well as protected for tests * FIxed interactive test for CollectionEditor * add flimsy functional test: * proper test helpers
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still not the most ideal solution if: Arcade changes where the logging directory is.