Split Rank1 MdArray allocation into a separate helper #84205
Conversation
MdArray rank1 with all-zero lower bounds gets actually allocated as an SzArray. On Native AOT this means we need to spin up to the type loader to potentially load the new type. Split this expensive (and impossible-to-express-in-C#) thing into a separate helper so we can trim the type loader. dotnet#84156 (comment)
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue DetailsMdArray rank1 with all-zero lower bounds gets actually allocated as an SzArray. On Native AOT this means we need to spin up to the type loader to potentially load the new type. Split this expensive (and impossible-to-express-in-C#) thing into a separate helper so we can trim the type loader. Cc @dotnet/ilc-contrib
|
...oreclr/nativeaot/System.Private.CoreLib/src/Internal/Runtime/CompilerHelpers/ArrayHelpers.cs
Outdated
Show resolved
Hide resolved
src/coreclr/tools/Common/Internal/Runtime/ReadyToRunConstants.cs
Outdated
Show resolved
Hide resolved
...oreclr/nativeaot/System.Private.CoreLib/src/Internal/Runtime/CompilerHelpers/ArrayHelpers.cs
Outdated
Show resolved
Hide resolved
...oreclr/nativeaot/System.Private.CoreLib/src/Internal/Runtime/CompilerHelpers/ArrayHelpers.cs
Outdated
Show resolved
Hide resolved
...oreclr/nativeaot/System.Private.CoreLib/src/Internal/Runtime/CompilerHelpers/ArrayHelpers.cs
Outdated
Show resolved
Hide resolved
...oreclr/nativeaot/System.Private.CoreLib/src/Internal/Runtime/CompilerHelpers/ArrayHelpers.cs
Outdated
Show resolved
Hide resolved
...oreclr/nativeaot/System.Private.CoreLib/src/Internal/Runtime/CompilerHelpers/ArrayHelpers.cs
Show resolved
Hide resolved
|
Cc @dotnet/jit-contrib since I'm touching the JIT. Also I know there's extra logistics to think about when JitInterface GUID is changed: I don't mind this waiting until a merge window opens. |
I don't think we have a strict rule around that. I personally try to merge such changes on weekends since SPMI re-collection is a bit fragile (takes a lot of time, some collections aren't automated yet), if @AndyAyersMS hasn't yet updated aspnet I assume we can merge this one today |
Merging today is fine by me. |
MdArray rank1 with all-zero lower bounds gets actually allocated as an SzArray. On Native AOT this means we need to spin up to the type loader to potentially load the new type. Split this expensive (and impossible-to-express-in-C#) thing into a separate helper so we can trim the type loader.
#84156 (comment)
Cc @dotnet/ilc-contrib