Skip to content

Adjust so that we only require FEAT_LSE for osx-arm64 and maccatalyst, not for iOS or tvOS #119032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 23, 2025
Merged

Adjust so that we only require FEAT_LSE for osx-arm64 and maccatalyst, not for iOS or tvOS #119032

merged 1 commit into from
Aug 23, 2025
+27 −8

Conversation

tannergooding
Copy link
Member

This resolves #119008

@Copilot Copilot AI review requested due to automatic review settings August 23, 2025 14:56
@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Aug 23, 2025
Copilot
Copilot AI reviewed Aug 23, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

This was referenced Aug 23, 2025
Open
Open
Open
kg
kg reviewed Aug 23, 2025
View reviewed changes
kg
kg approved these changes Aug 23, 2025
View reviewed changes
Copy link
Member

@kg kg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand this correctly, we still require AdvSIMD on every arm64 target (which makes sense, iirc it's part of the baseline), but we're changing things so LSE is only required on OSX and MacCatalyst and it's allowed to be missing on iOS and tvOS.

@tannergooding
Copy link
Member Author

If I understand this correctly, we still require AdvSIMD on every arm64 target (which makes sense, iirc it's part of the baseline), but we're changing things so LSE is only required on OSX and MacCatalyst and it's allowed to be missing on iOS and tvOS.

@kg, correct. If we have the minimum iOS/tvOS hardware supported then we can likely be a bit more explicit about them as well. But keeping it at the same as .NET 10 will resolve the CI failure for now (I expect iOS is higher than armv8.0-a in particular)

@tannergooding tannergooding merged commit 664eda9 into dotnet:main Aug 23, 2025
161 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@kg kg kg approved these changes

@MichalStrehovsky MichalStrehovsky Awaiting requested review from MichalStrehovsky MichalStrehovsky is a code owner

@kotlarmilos kotlarmilos Awaiting requested review from kotlarmilos

Assignees

@tannergooding tannergooding

Labels
needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

XHarness General Failure in tVOS.Device.Aot.Test
2 participants
@tannergooding @kg