Fix DateTimeOffset deserialization in IXmlSerializable context #119030
+59
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression introduced in .NET 7.0+ where
DateTimeOffset
values were incorrectly deserialized whenDataContractSerializer
was used withinIXmlSerializable.ReadXml()
methods.Problem
When deserializing
DateTimeOffset
in nested serialization scenarios, the UTC time component was being treated as local time instead of UTC time, causing incorrect results:This affected applications upgrading from .NET Framework/.NET 6.0 to .NET 7.0+, particularly CoreWCF applications.
Root Cause
In nested
DataContractSerializer
scenarios, the XML parsing context causes theDateTime.Kind
property to becomeUnspecified
instead ofUtc
. TheDateTimeOffsetAdapter.GetDateTimeOffset()
method incorrectly handled this case by treating the datetime as local time in the target timezone, when it should treat it as UTC time (matching the semantic meaning of theUtcDateTime
field).Solution
Modified the
DateTimeKind.Unspecified
case inDateTimeOffsetAdapter.GetDateTimeOffset()
to:Kind
propertyDateTimeOffset
from UTC and convert to the target offsetDateTimeKind.Utc
caseAdded a comprehensive regression test
DCS_DateTimeOffsetInIXmlSerializableContainer
to prevent future regressions.Verification
Fixes #114813.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.