Skip to content

Disable tests parallelization in flaky OleDB tests #119018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

roji
Copy link
Member

@roji roji commented Aug 22, 2025

There's reason to believe that the flakiness in #87783 is caused by concurrency issues in the ACE/Access OleDB driver being used (e.g. here). So as an easy attempt to get rid of the flakiness, I'm disabling parallelization altogether in these tests. I suggest we merge this and observe what happens in the next few days/weeks.

If this doesn't fix the flakiness, we should move away from ACE to SQL Server / LocalDB. There's a good chance we'd need to install components on the runner image though, so we'd probably want to skip the tests until that happens.

@jeffschwMSFT @jeffhandley @SamMonoRT

@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Aug 22, 2025
@roji roji added area-System.Data.OleDB and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Aug 22, 2025
Copy link
Contributor

Tagging subscribers to this area: @roji, @SamMonoRT
See info in area-owners.md if you want to be subscribed.

@roji roji force-pushed the OleDbTestHangs branch 2 times, most recently from fb60001 to 963fc33 Compare August 23, 2025 07:27
@roji roji marked this pull request as ready for review August 23, 2025 07:32
@Copilot Copilot AI review requested due to automatic review settings August 23, 2025 07:32
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses flaky OleDB tests by disabling test parallelization to work around concurrency issues in the ACE/Access OleDB driver.

  • Adds an AssemblyInfo.cs file to disable test parallelization for the OleDB test suite
  • Implements a temporary workaround for known concurrency issues in the Microsoft ACE OleDB driver

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant