Avoid Marshal.PtrToStructure in NativeWrapper
#118996
Open
+321
−359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoids an unnecessary cast to long on 32-bit systems, which could introduce inefficiency without providing any benefit.
|
Tagging subscribers to this area: @dotnet/area-system-diagnostics-eventlog |
jkotas
reviewed
Aug 22, 2025
src/libraries/System.Diagnostics.EventLog/src/System/Diagnostics/Reader/NativeWrapper.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Aug 22, 2025
src/libraries/System.Diagnostics.EventLog/src/System/Diagnostics/Reader/NativeWrapper.cs
Show resolved
Hide resolved
NativeWrapperMarshal.PtrToStructure in NativeWrapper
jkotas
reviewed
Aug 22, 2025
src/libraries/System.Diagnostics.EventLog/src/System/Diagnostics/Reader/NativeWrapper.cs
Outdated
Show resolved
Hide resolved
This was referenced Aug 22, 2025
jkotas
reviewed
Aug 22, 2025
src/libraries/System.Diagnostics.EventLog/src/System/Diagnostics/Reader/NativeWrapper.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Aug 23, 2025
| { | ||
| bool status = UnsafeNativeMethods.EvtRender(contextHandle, eventHandle, flag, 0, IntPtr.Zero, out bufferNeeded, out propCount); | ||
| bool status = UnsafeNativeMethods.EvtRender(contextHandle, eventHandle, flag, 0, (UnsafeNativeMethods.EvtVariant*)null, out int bufferNeeded, out int propCount); |
There was a problem hiding this comment.
Suggested change
| bool status = UnsafeNativeMethods.EvtRender(contextHandle, eventHandle, flag, 0, (UnsafeNativeMethods.EvtVariant*)null, out int bufferNeeded, out int propCount); | |
| bool status = UnsafeNativeMethods.EvtRender(contextHandle, eventHandle, flag, 0, null, out int bufferNeeded, out int propCount); |
Why do we need to cast here? Many other places pass in null just fine.
There was a problem hiding this comment.
Ah ok, I see there is an ambiguous overload. There seem to be more places that have the same problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids an unnecessary cast to long on 32-bit systems, which could introduce inefficiency without providing any benefit.
Best reviewed hiding whitespace changes.