Increase file descriptor limit in native AOT executables #118995
Merged
+78
−78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR consolidates file descriptor limit handling across .NET runtime components by moving the descriptor limit increase functionality from individual runtime implementations into the shared minipal library. This ensures consistent behavior across CoreCLR, Mono, and Native AOT executables.
Key changes:
- Creates a unified
minipal_increase_descriptor_limit()function in the minipal library - Removes duplicate descriptor limit code from CoreCLR PAL and Mono runtime
- Adds descriptor limit increase functionality to Native AOT bootstrap
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/native/minipal/descriptorlimit.h |
New header defining the minipal descriptor limit API |
src/native/minipal/descriptorlimit.c |
New implementation of descriptor limit increase functionality |
src/native/minipal/minipalconfig.h.in |
Adds HAVE_RESOURCE_H configuration check |
src/native/minipal/configure.cmake |
Adds sys/resource.h availability check |
src/native/minipal/CMakeLists.txt |
Includes new descriptor limit source and disables functionality on problematic platforms |
src/mono/mono/mini/driver.c |
Replaces local descriptor limit function with minipal version |
src/mono/CMakeLists.txt |
Removes redundant DONT_SET_RLIMIT_NOFILE definition |
src/coreclr/pal/src/init/pal.cpp |
Replaces local descriptor limit function with minipal version |
src/coreclr/pal/src/CMakeLists.txt |
Removes redundant DONT_SET_RLIMIT_NOFILE definition |
src/coreclr/nativeaot/Bootstrap/main.cpp |
Adds descriptor limit increase call to Native AOT bootstrap |
jkotas
reviewed
Aug 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #82719
Cc @dotnet/ilc-contrib