JIT: Switch GetElement and WithElement to native sized indices #118990
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
| @@ -23270,6 +23273,7 @@ GenTree* Compiler::gtNewSimdGetElementNode( | |||
| var_types simdBaseType = JitType2PreciseVarType(simdBaseJitType); | |||
|
|
|||
| assert(varTypeIsArithmetic(simdBaseType)); | |||
| assert(op2->TypeIs(TYP_I_IMPL)); | |||
There was a problem hiding this comment.
Just noting here, for explanation....
The reason that gtNewSimdGetElementNode took TYP_INT is because the underlying instruction takes TYP_BYTE.
The only time we actually consume it as TYP_I_IMPL is if it is non-constant and we must fallback to spilling the vector to memory and using the index dynamically.
| @@ -1590,7 +1590,7 @@ GenTree* Compiler::addRangeCheckForHWIntrinsic(GenTree* immOp, int immLowerBound | |||
| // The value of (immUpperBound - immLowerBound + 1) is denoted as adjustedUpperBound. | |||
|
|
|||
| const ssize_t adjustedUpperBound = (ssize_t)immUpperBound - immLowerBound + 1; | |||
| GenTree* adjustedUpperBoundNode = gtNewIconNode(adjustedUpperBound, TYP_INT); | |||
| GenTree* adjustedUpperBoundNode = gtNewIconNode(adjustedUpperBound, TYP_I_IMPL); | |||
There was a problem hiding this comment.
This ends up working because int32 - nativeint is defined, correct?
We have a lot of APIs that take TYP_UBYTE from the managed signature and which will only ever be [0, 255].
tannergooding
approved these changes
Aug 22, 2025
This was referenced Aug 22, 2025
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #118974