Add NoWASM label #1451
Add NoWASM label #1451
Conversation
| @@ -66,6 +66,7 @@ public int Read() | |||
| } | |||
|
|
|||
| [Benchmark] | |||
| [BenchmarkCategory(Categories.NoWASM)] | |||
There was a problem hiding this comment.
are file operations not supported in general on WASM or just the async ones?
There was a problem hiding this comment.
File operations do not seem to be allowed on WASM. From what I was able to glean from reading you need to hit a web endpoint if you want to access files.
There was a problem hiding this comment.
So maybe that would be something we could do long term, but for now we can just turn them off.
| @@ -17,6 +17,7 @@ public class Perf_CancellationToken | |||
| public void RegisterAndUnregister_Serial() => _token.Register(() => { }).Dispose(); | |||
|
|
|||
| [Benchmark(OperationsPerInvoke = 1_000_000)] | |||
| [BenchmarkCategory(Categories.NoWASM)] | |||
There was a problem hiding this comment.
For the multi-threaded tests, we could introduce a multithreaded category and use it to exclude the benchmarks when affinitizing to a single core. Sth like:
--filter * --category-exclusion-filter multithreaded --affinity XAnd the full WASM filter would be:
--filter * --category-exclusion-filter nowasm multithreaded|
btw @buyaa-n is currently working on an analyzer that is going to print warnings for os|platform specific APIs. When it's ready we could use it here to verify if our "nowasm" category is complete |
No description provided.