Support non-1xx feature bands in source-only validation jobs #2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In non-1xx feature band branches, there are no runtime-related vertical jobs. This is a problem for the source-only validation jobs which rely on the
Browser_Shortstack_wasmjob to retrieve the various WASM packages needed for testing because that job is not run in those branches.The solution is to conditionally depend on that job so that we don't depend on it outside 1xx scenarios. But we still need to have the packages. So the test project dynamically downloads the required WASM packages from the related build produced by the 1xx branch.
Contributes to #1011