Skip to content

Add PR pipeline stage to validate VMR changes #1270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 45 commits into from
Aug 18, 2025

Conversation

adamzip
Copy link
Contributor

@adamzip adamzip commented Jun 20, 2025

@adamzip adamzip requested review from a team as code owners June 20, 2025 14:13
@adamzip adamzip force-pushed the add-vmr-change-validation-stage branch 3 times, most recently from 63faec3 to 910d34f Compare June 20, 2025 14:57
@premun
Copy link
Member

premun commented Jun 20, 2025

@adamzip as we spoke earlier - it would probably be good to comment out the other stages so that we don't block compute for no reason (and since there are iterations to be expected)

Copy link
Member

@jkoritzinsky jkoritzinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like with the other change validation tooling, I think this could be better written as a one or two line script in a bash script.

@premun
Copy link
Member

premun commented Jun 23, 2025

@jkoritzinsky please note that there will be a whole suite of checks we will run and many will use existing functionality from Maestro to parse source-manifest and source-mappings: dotnet/arcade-services#2950

For this reason, C# will be more tenable long-term. Existing GHA checks from Ella will be ported to C# too.

@adamzip adamzip force-pushed the add-vmr-change-validation-stage branch from e056e68 to 78a6e64 Compare July 21, 2025 12:19
@adamzip adamzip force-pushed the add-vmr-change-validation-stage branch 2 times, most recently from 5e5684f to 918d9ab Compare August 6, 2025 00:23
Copy link
Member

@premun premun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I think we're almost there. This is a last batch of comments I have.

@adamzip adamzip force-pushed the add-vmr-change-validation-stage branch from 9fa34c8 to 78d4442 Compare August 10, 2025 11:26
@premun
Copy link
Member

premun commented Aug 11, 2025

/azp run

@premun
Copy link
Member

premun commented Aug 11, 2025

@adamzip we will have to force-merge tomorrow

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@adamzip
Copy link
Contributor Author

adamzip commented Aug 14, 2025

/ba-g introducing new validation feature

@adamzip adamzip force-pushed the add-vmr-change-validation-stage branch from 40a189a to d645e97 Compare August 18, 2025 08:54
@premun premun merged commit 5c3434d into dotnet:main Aug 18, 2025
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants