-
Notifications
You must be signed in to change notification settings - Fork 185
Add PR pipeline stage to validate VMR changes #1270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
63faec3
to
910d34f
Compare
@adamzip as we spoke earlier - it would probably be good to comment out the other stages so that we don't block compute for no reason (and since there are iterations to be expected) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like with the other change validation tooling, I think this could be better written as a one or two line script in a bash script.
@jkoritzinsky please note that there will be a whole suite of checks we will run and many will use existing functionality from Maestro to parse For this reason, C# will be more tenable long-term. Existing GHA checks from Ella will be ported to C# too. |
e056e68
to
78a6e64
Compare
5e5684f
to
918d9ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I think we're almost there. This is a last batch of comments I have.
9fa34c8
to
78d4442
Compare
/azp run |
@adamzip we will have to force-merge tomorrow |
Azure Pipelines successfully started running 2 pipeline(s). |
/ba-g introducing new validation feature |
40a189a
to
d645e97
Compare
dotnet/arcade-services#5155