Skip to content

[release/10.0-rc2] Don't add "unknown" to Blazor metrics tags when values are null #63383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: release/10.0
Choose a base branch
from
Open

[release/10.0-rc2] Don't add "unknown" to Blazor metrics tags when values are null #63383

wants to merge 4 commits into from
+196 −34

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 22, 2025 •
edited by pavelsavara
Loading

Backport of #63351 to release/10.0-rc1

/cc @pavelsavara @copilot

Don't add "unknown" to Blazor metrics tags when values are null

A more standard behavior is to not include tags when no value is available for it.

Description

Fixes #63350

Regression?

  • Yes
  • No

These metrics are new in Net10

[If yes, specify the version the behavior has regressed from]

Risk

  • High
  • Medium
  • Low

[Justify the selection above]

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

Copilot AI and others added 4 commits August 22, 2025 13:30
@Copilot
Initial plan
c0da3f3
@Copilot @JamesNK
Implement conditional tag addition to remove "unknown" values from Bl…
ebbcfd7 
…azor metrics

Co-authored-by: JamesNK <303201+JamesNK@users.noreply.github.com>
@JamesNK
Update src/Components/Components/src/ComponentsMetrics.cs
4935dde
@Copilot @ilonatommy
Improve readability by extracting exception type name to local variable
7e1e101 
Co-authored-by: ilonatommy <32700855+ilonatommy@users.noreply.github.com>
@github-actions github-actions bot requested a review from a team as a code owner August 22, 2025 13:30
@pavelsavara pavelsavara added the area-blazor Includes: Blazor, Razor Components label Aug 22, 2025
@pavelsavara pavelsavara added this to the 10.0-rc2 milestone Aug 22, 2025
@pavelsavara pavelsavara mentioned this pull request Aug 22, 2025
Closed
@build-analysis build-analysis bot mentioned this pull request Aug 22, 2025
Open
@akoeplinger akoeplinger changed the base branch from release/10.0-rc1 to release/10.0 August 22, 2025 17:09
@akoeplinger akoeplinger changed the title [release/10.0-rc1] Don't add "unknown" to Blazor metrics tags when values are null [release/10.0] Don't add "unknown" to Blazor metrics tags when values are null Aug 22, 2025
@akoeplinger akoeplinger changed the title [release/10.0] Don't add "unknown" to Blazor metrics tags when values are null [release/10.0-rc2] Don't add "unknown" to Blazor metrics tags when values are null Aug 22, 2025
@pavelsavara pavelsavara added the Servicing-consider Shiproom approval is required for the issue label Aug 23, 2025
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Hi @@github-actions[bot]. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge.

To learn more about how to prepare a servicing PR click here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pavelsavara pavelsavara

@JamesNK JamesNK

Labels
area-blazor Includes: Blazor, Razor Components Servicing-consider Shiproom approval is required for the issue
Projects
None yet
Milestone
10.0-rc2
Development

Successfully merging this pull request may close these issues.
3 participants
@pavelsavara @JamesNK @Copilot