Unblock NavigationLock_OverlappingNavigationsCancelExistingNavigations_HistoryNavigation
#63357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR unblocks a quarantined test NavigationLock_OverlappingNavigationsCancelExistingNavigations_HistoryNavigation that was experiencing timing-related failures. The fix addresses a race condition where CSS element selectors were being checked before the page was fully loaded after navigation.
- Removes the
[QuarantinedTest]attribute to unblock the test - Adds a synchronization check to ensure navigation completion before verifying CSS selectors
|
@ilonatommy have you looked at the quarantined test data to see the pass rate? |
That test is not listed among failing tests in the last 30 days. |
pavelsavara
approved these changes
Aug 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test was quarantined but I cannot reproduce the failure. The issue log indicates that the failure occurred on checking css element selector that was not present. It looks like a timing issue that could have happened if the page was not fully loaded at the time of the check. We can avoid it by adding another check that waits for the page to be loaded.
Description
Fixes #61080