Fixes in PrefixResolver #63334
Merged
Fixes in PrefixResolver #63334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes issues in the PrefixResolver component to improve form binding logic, particularly for recursive model binding scenarios. The changes enhance segment comparison accuracy in the FormKeyComparer and add comprehensive test coverage to verify the fixes work correctly.
- Refactored the
FormKeyComparerlogic to handle edge cases where keys have different numbers of segments - Added comprehensive unit tests to verify prefix detection works for both positive and negative scenarios
- Created an E2E test with a supporting Razor page to validate recursive form binding functionality
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
PrefixResolver.cs |
Simplified and fixed the FormKeyComparer logic to properly handle segment comparison when keys have different segment counts |
PrefixResolverTests.cs |
Added new unit tests to verify prefix detection behavior with matching and non-matching entries |
FormWithParentBindingContextTest.cs |
Added E2E test to verify recursive form binding works end-to-end |
RecursiveEditFormBinding.razor |
New test page supporting the E2E test with a recursive model structure |
9eeb34e to
4aa4eb3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes in PrefixResolver
Description
This pull request improves the form binding logic and its test coverage, particularly around recursive model binding scenarios and prefix resolution. The main changes include enhancements to the
FormKeyComparerfor more reliable segment comparison, new and expanded unit tests for prefix handling, and the addition of a new E2E test and supporting Razor page for recursive form binding.Changes:
FormKeyComparerlogic inPrefixResolver.csto improve segment comparison accuracy, especially when handling cases where one key has more segments than the other. This makes prefix resolution more robust and correct.PrefixResolverTests.csto verify correct behavior of prefix detection with and without matching entries, ensuring the resolver works for both positive and negative scenarios.FormWithParentBindingContextTest.csthat verifies recursive form binding works as expected, including input and form submission behavior.Fixes #61341