Enable E2ETest.ServerExecutionTests.CircuitTests
#63143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR enables previously quarantined E2E tests for circuit termination by adding error UI dismissal logic. The tests were quarantined because error dialogs were overlapping buttons needed for subsequent test steps.
Key changes:
- Removes
QuarantinedTestattributes from two test methods - Adds error UI dismissal logic to ensure test buttons remain accessible
3 tasks
auto-merge was automatically disabled
August 20, 2025 06:49
Pull request was closed
oroztocil
approved these changes
Aug 20, 2025
|
@MackinnonBuck, I'm setting for automerge, feel free to let us know if the test's intention was to click the button with the popup opened and we'll revert. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test checks if we correctly terminate the circuit after an exception was thrown. The check if the circuit was terminated involves clicking a button that got hidden by error window with the throw exception.
There was an attempt to fix it by moving the window position, so that the button becomes visible. Why don't we close the window to make sure button visibility is not a problem?
Fixes #57551